-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding a test suite and continuous integration #16
Comments
@grlee77 Thank you for your comments regarding automated testing/CI. We have been discussing this internally and plan to incorporate the same in our next major release (2.0.0) as a part of ISMRM 2021 efforts. |
@grlee77 Can this issue be closed? |
It does not hurt to keep the issue open as a reminder to add this in the future. You could remove the "review comment" label and add a label like "task" to indicate that the issue is task-related and not a bug. Ultimately, it is up to you whether you find it useful to keep this open or not, though. |
Completely on board about the benefits of CI - will incorporate it in the future, thank you for your inputs. |
Is your feature request related to a problem? Please describe.
In considering the JOSS review criteria, I think the lack of a test suite or any type of continuous integration to verify correct operation across platforms / software versions is the biggest weakness.
There are fortunately a number of demos that the user can run to verify the basic operation of the package, but I did see any automated way to run tests.
Describe the solution you'd like
Ideally some automated unit tests would be created. The pytest package is a popular choice for this.
Once unit tests have been defined, services like Travis-CI, Circle-CI, Appveyor and/or Azure can be used to set up automated cross-platform testing on each pull request, etc. This may be overkill at the moment for a project of this size, but something to keep in mind.
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: