Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems that the histogram loss is unused #1

Open
Vermeille opened this issue May 26, 2020 · 2 comments
Open

It seems that the histogram loss is unused #1

Vermeille opened this issue May 26, 2020 · 2 comments

Comments

@Vermeille
Copy link

Hi,

According to my understanding of this line, the histogram rematched imaged is computed but never used again, and not part of the loss.

https://github.com/imransalam/style-transfer-tensorflow-2.0/blob/master/synthesis.py#L69

Is this a bug?

@lincong666
Copy link

Hi,

According to my understanding of this line, the histogram rematched imaged is computed but never used again, and not part of the loss.

https://github.com/imransalam/style-transfer-tensorflow-2.0/blob/master/synthesis.py#L69

Is this a bug?

Yes,its authors mistake!

@imransalam
Copy link
Owner

Hey, yes this seems to be a mistake. You can create a PR for it if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants