Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order action in ResendConfirmationMail plugin #617

Open
klodeckl opened this issue Nov 14, 2024 · 4 comments · May be fixed by #618
Open

Wrong order action in ResendConfirmationMail plugin #617

klodeckl opened this issue Nov 14, 2024 · 4 comments · May be fixed by #618
Assignees
Milestone

Comments

@klodeckl
Copy link

Hello,

the resend confirmation mail plugin is broken because of the wrong order in \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin in ext_localconf.php

It is:

    \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
        'Femanager',
        'ResendConfirmationMail',
        [
            \In2code\Femanager\Controller\NewController::class => 'confirmCreateRequest, createStatus, resendConfirmationMail, resendConfirmationDialogue',
        ],
        [
            \In2code\Femanager\Controller\NewController::class => 'confirmCreateRequest, createStatus, resendConfirmationMail, resendConfirmationDialogue',
        ],
        \TYPO3\CMS\Extbase\Utility\ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT
    );

But it should be:

    \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
        'Femanager',
        'ResendConfirmationMail',
        [
            \In2code\Femanager\Controller\NewController::class => 'resendConfirmationDialogue, confirmCreateRequest, createStatus, resendConfirmationMail',
        ],
        [
            \In2code\Femanager\Controller\NewController::class => 'resendConfirmationDialogue, confirmCreateRequest, createStatus, resendConfirmationMail',
        ],
        \TYPO3\CMS\Extbase\Utility\ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT
    );

Otherwise the wrong action (confirmCreateRequest) is called.

@sbusemann
Copy link
Contributor

Which version?

@klodeckl
Copy link
Author

klodeckl commented Nov 14, 2024

Version is current main branch here.
TYPO3 12.4.23

@sbusemann
Copy link
Contributor

confirmed with 8.2.1

sbusemann added a commit that referenced this issue Nov 14, 2024
@sbusemann sbusemann linked a pull request Nov 14, 2024 that will close this issue
@sbusemann
Copy link
Contributor

todos:

  • add feature to feature doc list
  • add test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants