Views cleanup

[pardo-bsso]

Just some low hanging fruit while I rework stateful views. I need it anyways.
If we agree on what is the expected behaviour I'll rebase #214 on top of this.
I avoided touching the config view on purpose.

[xaiki]

looks good apart from the usual style nitpicks.
but I can see the rest of the file is out of style too.
so fix the most important ones, the rest can go in.

[pardo-bsso]

looks good apart from the usual style nitpicks.
but I can see the rest of the file is out of style too.
so fix the most important ones, the rest can go in.

Ok, will redo and push again.

Thanks.

[darthpolly]

Mind that PanelView is an extension of MasterView. PanelView only adds the toggleSide method which shows and hides the side panel. If you're implementing views without panels, such as MediaList and MediaDetails, they should extend MasterView.

Also there's a hierarchy in templates, mediaedit.jade:1 extends panelview.jade which extends masterview.jade. The idea behind MasterView was to add global mechanics common to all views (now there's only an alert which prevents you leaving the view without saving), so if you don't extend the template too, that mechanics won't work. Again, in MediaList and MediaDetails templates you can directly extend masterview.jade.

[pardo-bsso]

On 11 February 2014 11:59, Patricio Reboratti [email protected] wrote:

Mind that PanelView is an extension of MasterView. PanelView only adds the toggleSide
method which shows and hides the side panel. If you're implementing views without panels,
such as MediaList and MediaDetails, they should extend MasterView.

Ok, I just did it that way and worked for me. Changed them to extend
from MasterView.