-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opaque state as a type declaration #354
Conversation
989f870
to
80e2e6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case for this and, if needed, update the corresponding docs?
Thanks.
80e2e6f
to
cdb2f2b
Compare
cdb2f2b
to
0cdccb6
Compare
The previous implementation was incorrect. I've fixed that and rebased with some test cases. And also provided cases to verify rule But something looks weird to me. In the |
I'm not 100% sure, but it's likely because we're not running the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the PR, in general.
So, if you don't have time or just don't feel like improving the gen_server
s, let me know and I'll merge it.
OTOH, if you can improve that code (even when it's just for tests), that would be lovely.
test/examples/fail_state_record_and_type_plus_export_used_types.erl
Outdated
Show resolved
Hide resolved
test/examples/fail_state_record_and_type_plus_export_used_types.erl
Outdated
Show resolved
Hide resolved
Of course, I will improve those codes in test cases. |
Fix #349