Breaking: update atom naming convention's default regex #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
requested changes
Sep 12, 2024
elbrujohalcon
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Sorry, @bormilan … I think we still need another iteration on this.
paulo-ferraz-oliveira
changed the title
|
It'd be interesting to understand if this is interface-breaking, and signal that as a major in the release, in case it is, because we're changing an existing rule. |
elbrujohalcon
approved these changes
Sep 16, 2024
|
I'll merge this as soon as CI is ✅ … @paulo-ferraz-oliveira I do believe that this deserves a major jump. So… 4.0.0 is coming!!! |
|
To be clear: I would not release 4.0.0 yet… I would pick a few more tickets to tackle before it goes out. I'll make a milestone and associate a few issues with it. |
|
There you go, folks: https://github.com/inaka/elvis_core/milestone/7 |
paulo-ferraz-oliveira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.