Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write a readme #4

Closed
6 tasks
PietrH opened this issue Nov 10, 2023 · 2 comments · Fixed by #34
Closed
6 tasks

write a readme #4

PietrH opened this issue Nov 10, 2023 · 2 comments · Fixed by #34
Labels
documentation Improvements or additions to documentation

Comments

@PietrH
Copy link
Member

PietrH commented Nov 10, 2023

Ideally we'd also add a vignette on how to use the package, but this is something for beyond v0.1.

Things to mention in the readme:

  • Why did we make this package, mention that we want it to be broadly applicable for all iAsset users, but that our focus is currently on Vespa-Watch and RIPARIAS
  • What is the scope of the package (currently reading records, not changing them)
  • Refer to the iAsset API documentation
  • What can you do with the package; functions; get_access_token() for a token, get_records() to get records and get_fields() to get information about the fields
  • (optional) Mention Vespa-Watch as funding?
  • An example (excluding passwords, usernames or keys!) or how to get records out of iAsset
@PietrH PietrH added the documentation Improvements or additions to documentation label Nov 10, 2023
@PietrH PietrH modified the milestones: Get a tibble out! , v0.1 Nov 14, 2023
@PietrH
Copy link
Member Author

PietrH commented Dec 13, 2023

@SanderDevisscher Would you be willing to tackle this?

@PietrH
Copy link
Member Author

PietrH commented Dec 18, 2023

I think the basic example could be something like;

# You need an access token to talk to the iAsset API. You can reuse this token
# over multiple requests, but you need to request a new one at least once every
# 24 hours.
my_token <- get_access_token("my_username")
# By default the package will only look on the `riparias` domain, and only for
# the `Vespa-Watch` custom inspection. If you don't provide an access token, the
# package will try to create one.
get_records(inspection_name = "Vespa-Watch", access_token = my_token)

It would be great if we could include a few rows of output as well, but we'd need to be really careful on what data we put in there.

SanderDevisscher added a commit that referenced this issue Dec 18, 2023
@SanderDevisscher SanderDevisscher linked a pull request Feb 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant