Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room seems to be ignoring its size #94

Open
nitzanbueno opened this issue Jun 11, 2017 · 1 comment
Open

Room seems to be ignoring its size #94

nitzanbueno opened this issue Jun 11, 2017 · 1 comment

Comments

@nitzanbueno
Copy link

When adding users to a room using Room.addMember(user), the room allows an unlimited number of players to join and always returns "true", even though its room size shouldn't be allowing it.

@incompl
Copy link
Owner

incompl commented Jun 12, 2017

Hi @nitzanbueno, I'm not actively maintaining this project at this time, but if you want to take a look the problem may be that the room size isn't consider in addMember in this file: https://github.com/incompl/cloak/blob/master/src/server/cloak/room.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants