Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14098 JIRA Review configuration in JSON, XML and YAML #401 #407

Closed
wants to merge 1 commit into from

Conversation

himanshu608
Copy link
Collaborator

added contentType to convertConfigFormat,
so that we can convert from any format instead of using json

added contentType state to help conersion from any config type

added feature to review configuration in JSON XML and YAML format

Toggle Radios for JSON XML and YAML configurations

added contentType for format conversion api call

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work.
  • Commit message includes a reference to the corresponding JIRA issue (eg. commit message: "ISPN-1234 JIRA TITLE...").
  • Commits have been squashed and self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed).
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.

…#401

added contentType to convertConfigFormat,
so that we can convert from any format instead of using json

added contentType state to help conersion from any config type

added feature to review configuration in JSON XML and YAML format

Toggle Radios for JSON XML and YAML configurations

added contentType for format conversion api call
@himanshu608 himanshu608 closed this Oct 8, 2023
@himanshu608 himanshu608 deleted the ISPN-14098 branch October 8, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant