Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-15105 Console black theme #420

Merged
merged 1 commit into from
Oct 27, 2023
Merged

ISPN-15105 Console black theme #420

merged 1 commit into from
Oct 27, 2023

Conversation

himanshu608
Copy link
Collaborator

Description

Changes to add theme switch.

How Has This Been Tested?

Tested locally

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work.
  • Commit message includes a reference to the corresponding JIRA issue (eg. commit message: "ISPN-1234 JIRA TITLE...").
  • Commits have been squashed and self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed).
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.

@himanshu608 himanshu608 requested a review from karesti October 27, 2023 09:43
@karesti karesti force-pushed the ISPN-15105_THEME branch 2 times, most recently from 48e6f4d to bd12541 Compare October 27, 2023 13:37
karesti
karesti approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!!!! thanks a lot for this contribution!!

@karesti
Copy link
Collaborator

karesti commented Oct 27, 2023

@himanshu608 don't worry about the badges on the cache detail, I will handle those myself

@karesti karesti merged commit e44e45b into infinispan:main Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karesti karesti karesti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshu608 @karesti