Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial queries tutorial Closes #263 #274

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

fax4ever
Copy link

@fax4ever fax4ever commented Nov 15, 2024

Closes #263

To test it you need to create a snapshot build from the contribution infinispan/infinispan#13045.

@fax4ever fax4ever requested a review from karesti November 15, 2024 14:43
Copy link
Contributor

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only missing change is the documentation and a dependency version seems missing in the pom.xml!
Nice job!!

infinispan-remote/spatial-queries/pom.xml Outdated Show resolved Hide resolved
@karesti
Copy link
Contributor

karesti commented Nov 21, 2024

@fax4ever we are not using ISPN JIRA anymore for this project. A Github issue already exists for this tutorial:

#263

Please update the message of the PR too and add Closes #263 in the commit message please

@karesti
Copy link
Contributor

karesti commented Nov 21, 2024

The build should work with the latest snapshot version if using docker or podman locally

@karesti karesti changed the title ISPN-16846 Spatial queries tutorial Spatial queries tutorial Closes #263 Nov 21, 2024
@fax4ever
Copy link
Author

Thanks @karesti I applied the changes.

@karesti
Copy link
Contributor

karesti commented Nov 25, 2024

@fax4ever there is an issue in the pom

Error: ] Some problems were encountered while processing the POMs:
Error:  Non-resolvable import POM: The following artifacts could not be resolved: org.infinispan:infinispan-bom:pom:15.1.0-SNAPSHOT (absent): Could not find artifact org.infinispan:infinispan-bom:pom:15.1.0-SNAPSHOT @ line 17, column 25
Warning:  The expression ${version} is deprecated. Please use ${project.version} instead. @ 
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project org.infinispan.tutorial.simple:infinispan-simple-tutorials-spatial-queries:1.0.0-SNAPSHOT (/home/runner/work/infinispan-simple-tutorials/infinispan-simple-tutorials/infinispan-remote/spatial-queries/pom.xml) has 1 error
Error:      Non-resolvable import POM: The following artifacts could not be resolved: org.infinispan:infinispan-bom:pom:15.1.0-SNAPSHOT (absent): Could not find artifact org.infinispan:infinispan-bom:pom:15.1.0-SNAPSHOT @ line 17, column 25 -> [Help 2]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
Error:  [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

@karesti karesti changed the base branch from main to development November 25, 2024 09:18
@karesti
Copy link
Contributor

karesti commented Nov 25, 2024

@fax4ever rebase. target development branch

@fax4ever
Copy link
Author

fax4ever commented Nov 26, 2024

Hi @karesti. I rebased and I got an error that is the same if run a build from the base infinispan:development branch. So I'm not really sure it is related this contribution.

This is the error:

(base) fax@fax-workstation:~/code/infinispan-simple-tutorials$ git checkout development 
Switched to branch 'development'
Your branch is up to date with 'origin/development'.
(base) fax@fax-workstation:~/code/infinispan-simple-tutorials$ mvn clean install -pl infinispan-remote/query/
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.infinispan:infinispan-hotrod:jar is missing. @ line 45, column 21
[WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. @ 
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.infinispan.tutorial.simple:infinispan-simple-tutorials-reactive:1.0.0-SNAPSHOT (/home/fax/code/infinispan-simple-tutorials/infinispan-remote/reactive-api/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for org.infinispan:infinispan-hotrod:jar is missing. @ line 45, column 21
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

@karesti
Copy link
Contributor

karesti commented Nov 26, 2024

@fax4ever you're right, developement branch is broken
I'll fix it. I don't want to merge this before that

@karesti
Copy link
Contributor

karesti commented Nov 26, 2024

@fax4ever you also need to update the docs

@karesti
Copy link
Contributor

karesti commented Nov 26, 2024

@fax4ever you can merge this one and rebase #283

@fax4ever
Copy link
Author

Rebased on top of fix! It worked... I'm updating the docs

@fax4ever
Copy link
Author

@karesti I updated the doc with the last push

@karesti karesti merged commit 07570f6 into infinispan:development Nov 27, 2024
1 check passed
@fax4ever
Copy link
Author

Thanks @karesti

@fax4ever fax4ever deleted the ISPN-16846 branch November 27, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geo Search simple tutorial
2 participants