Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tintColor dark mode in expo/new arch template #2841

Open
csulit opened this issue Nov 10, 2024 · 3 comments
Open

Image tintColor dark mode in expo/new arch template #2841

csulit opened this issue Nov 10, 2024 · 3 comments
Labels

Comments

@csulit
Copy link

csulit commented Nov 10, 2024

Describe the bug

I though the new architecture seems to have broken the theming for the image in the Ignite template when using the Expo router. The image tint color does not change when toggling to dark mode. However, when I remove the theme.isDark check and replace it with just the theme.colors.palette.neutral900, the color changes correctly between dark and light modes.

Works fine:

  <Image
    style={$welcomeFace}
    source={welcomeFace}
    resizeMode="contain"
    tintColor={theme.colors.palette.neutral900}
  />

Doesn't work:

  <Image
    style={$welcomeFace}
    source={welcomeFace}
    resizeMode="contain"
    tintColor={theme.isDark ? theme.colors.palette.neutral900 : undefined}
  />

Ignite version

10.0.4

Additional info

n/a

@csulit csulit added the bug label Nov 10, 2024
@coolsoftwaretyler
Copy link
Contributor

Thanks!

We talked through this a little in Slack, but for other observers, I think this came through in: https://github.com/infinitered/ignite/pull/2636/files#diff-b0449a4720536aeac295ae925d29bb4f9c16b69d3c6da061a70dfc19c15b4a5eR59

Should be a quick PR to swap out tintColor and just use tintColor={theme.colors.palette.neutral900}

@csulit
Copy link
Author

csulit commented Nov 10, 2024

Just to document I want to contribute more on this project 🎉🍾

@coolsoftwaretyler
Copy link
Contributor

@csulit - this would be an excellent way to start contributing if you want to fork and send us a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants