fix(boilerplate): web platform fixes #2856
Open
+24
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn test
jest tests pass with new tests, if relevantyarn lint
eslint checks pass with new code, if relevantyarn format:check
prettier checks pass with new code, if relevantREADME.md
(or relevant documentation) has been updated with your changesDescribe your PR
useEffect
issue highlighted here: [web] useLayoutEffect + navigating with initial: false causing a crash react-navigation/react-navigation#11748setImmediate
issue highlighted here: setImmediate is not defined necolas/react-native-web#1891 (comment)WelcomeScreen
displaying on Web properlytoggleDrawer
being fired inhandleScroll
because it was getting caught in a loop (set state is bad in an effect anyway). So the drawer doesn't close upon clicking a nav item but it's much nicer than it not working (plus we have plans to remove the drawer from the demo application)Screenshots (if applicable)
Web
Regression check against mobile devices