Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Wrapper "Hide" option does not apply to all blocks properly #39

Open
piqusy opened this issue Sep 4, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@piqusy
Copy link
Contributor

piqusy commented Sep 4, 2024

Hide works for Group but not for e.g. Heading & Columns blocks

A hidden class is added to the wrapper but only hides the wrapper in smallest breakpoint which.

Here is a Gutenberg code editor example:

<!-- wp:eightshift-boilerplate/heading {"wrapperWidth":"contained-wide-bg","wrapperBackground":"solid-grey-800","wrapperHide":{"_default":"true","_desktopFirst":true},"wrapperMarginTop":{"_default":"lg","_desktopFirst":true},"wrapperMarginBottom":{"_default":"none","_desktopFirst":true},"wrapperPaddingTop":{"_default":"md","_desktopFirst":true},"wrapperPaddingBottom":{"_default":"md","_desktopFirst":true},"headingHeadingContent":"Trainings","headingHeadingSize":"5xl","headingColor":"white"} /-->

<!-- wp:eightshift-boilerplate/columns {"wrapperWidth":"contained-wide-bg","wrapperBackground":"solid-grey-800","wrapperHide":{"_default":"true","_desktopFirst":true},"wrapperPaddingTop":{"_default":"xl","_desktopFirst":true},"wrapperPaddingBottom":{"_default":"xl","_desktopFirst":true},"columnsNumOfColumns":{"_default":"2","_desktopFirst":true,"max-sm":"1"},"columnsRowHeight":{"_default":"equal","_desktopFirst":true}} -->
<!-- wp:eightshift-boilerplate/column {"columnOffset":{"_default":"1","_desktopFirst":true,"max-sm":"1"},"columnWidth":{"_default":"1","_desktopFirst":true,"max-sm":"1"}} -->
<!-- wp:eightshift-boilerplate/pricing {"wrapperNoWidthControls":true,"wrapperWidth":"none","pricingHeadingContent":"CloudVane Basic","pricingPriceContent":"€999","pricingSubtitleContent":"Subtitle","pricingSubtitleUse":false,"pricingParagraphContent":"CloudVane enables you to, quickly and with ease, implement FinOps best practices which provide a new operating model for the cloud.","pricingCtaContent":"Apply now","pricingButtonContent":"Learn more"} -->
<!-- wp:eightshift-boilerplate/list {"wrapperUse":false,"wrapperNoWidthControls":true,"wrapperWidth":"off","listListContent":"\u003cli\u003e1-day training\u003c/li\u003e","listListStyle":"clocks","listListSize":"lg","listTextColor":"grey-800","listMarkerColor":"grey-800"} /-->

<!-- wp:eightshift-boilerplate/list {"wrapperUse":false,"wrapperNoWidthControls":true,"wrapperWidth":"off","listListContent":"\u003cli\u003eIntroduction into FinOps and Cloud Cost Management\u003c/li\u003e\u003cli\u003eSetting up your CloudVane account\u003c/li\u003e\u003cli\u003eAdministration and Security\u003c/li\u003e\u003cli\u003eHow to get insights into your cloud cost data\u003c/li\u003e\u003cli\u003eOptimize your environment to best suit your needs and invest into innovation\u003c/li\u003e\u003cli\u003eBest way to automate your day to day tasks\u003c/li\u003e\u003cli\u003eActing on recommendations for better cloud operation\u003c/li\u003e","listListStyle":"checks","listListSize":"lg","listTextColor":"grey-800","listMarkerColor":"green-300"} /-->
<!-- /wp:eightshift-boilerplate/pricing -->
<!-- /wp:eightshift-boilerplate/column -->

<!-- wp:eightshift-boilerplate/column {"columnOffset":{"_default":"2","_desktopFirst":true,"max-sm":"1"},"columnWidth":{"_default":"1","_desktopFirst":true,"max-sm":"1"}} -->
<!-- wp:eightshift-boilerplate/pricing {"wrapperNoWidthControls":true,"wrapperWidth":"none","pricingHeadingContent":"FinOps Basic","pricingPriceContent":"€999","pricingSubtitleContent":"Subtitle","pricingSubtitleUse":false,"pricingParagraphContent":"CloudVane enables you to, quickly and with ease, implement FinOps best practices which provide a new operating model for the cloud.","pricingCtaContent":"Apply now","pricingButtonContent":"Learn more"} -->
<!-- wp:eightshift-boilerplate/list {"wrapperUse":false,"wrapperNoWidthControls":true,"wrapperWidth":"off","listListContent":"\u003cli\u003e1-day training\u003c/li\u003e","listListStyle":"clocks","listListSize":"lg","listTextColor":"grey-800","listMarkerColor":"grey-800"} /-->

<!-- wp:eightshift-boilerplate/list {"wrapperUse":false,"wrapperNoWidthControls":true,"wrapperWidth":"off","listListContent":"\u003cli\u003eWhat is FinOps\u003c/li\u003e\u003cli\u003eThe FinOps team\u003c/li\u003e\u003cli\u003eWhat is driving cloud costs?\u003c/li\u003e\u003cli\u003eHow to easily identify opportunities to reduce costs\u003c/li\u003e\u003cli\u003eHow to distribute responsibility to optimize stakeholders’ costs\u003c/li\u003e","listListStyle":"checks","listListSize":"lg","listTextColor":"grey-800","listMarkerColor":"green-300"} /-->
<!-- /wp:eightshift-boilerplate/pricing -->
<!-- /wp:eightshift-boilerplate/column -->
<!-- /wp:eightshift-boilerplate/columns -->
@piqusy piqusy added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants