Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fluvio topic describe with additional information #3968

Open
ajhunyady opened this issue Apr 24, 2024 · 8 comments
Open

Improve fluvio topic describe with additional information #3968

ajhunyady opened this issue Apr 24, 2024 · 8 comments
Labels
CLI good first issue Good for newcomers help wanted Good issue for community involvement no-stale Opt-out of closing issue due to no activity

Comments

@ajhunyady
Copy link
Contributor

ajhunyady commented Apr 24, 2024

The current fluvio topic describe has been built 3 years ago and it's stale.

We should update this command with the following information:

$ fluvio topic describe my-topic
Name         : my-topic
Replication  : 1
Partitions   : 2 
State        : Provisioned

PARTITION    LEADER   LAST-OFFSET    LAST-PRODUCED   CONSUMERS
0            5001       3,543          1 sec ago       c1, c2
1            5002       1,240          5 sec ago       c3

Note

Let's start with the client approach, as calculating and adding a PartitionStatus object on the SC is a bigger effort.

  • To get last offset, use LEO (Last End Offset).
  • To get last produced, get last event and get timestamp of the event. This could be done in the client (easier) or can be
  • To get consumers, use fluvio consumer list as guidance.
@ajhunyady ajhunyady added bug Something isn't working help wanted Good issue for community involvement good first issue Good for newcomers CLI and removed bug Something isn't working labels Apr 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
@digikata digikata added no-stale Opt-out of closing issue due to no activity and removed no-issue-activity labels Jul 2, 2024
@digikata digikata reopened this Jul 2, 2024
@infinyon infinyon deleted a comment from github-actions bot Aug 21, 2024
@diogopontual
Copy link
Contributor

Hey @ajhunyady... With some delay, I started fixing this issue. I have two questions:

  1. I am assuming that LAST-OFFSET refers to status.leader.leo; Is that right?
  2. IDK which field to use to calculate LAST-PRODUCED.

TY

@ajhunyady
Copy link
Contributor Author

@diogopontual very cool!
@sehz can you please help with identify the right field?

@sehz
Copy link
Contributor

sehz commented Sep 5, 2024

Confirm.
To get last offset, use LEO (Last End Offset).
To get last produced, get last event and get timestamp of the event. This could be done in the client (easier) or can be calculated in the SC (that's more restructuring) and add to PartitionStatus but that's bigger efforts. So let's start with client approach

@ajhunyady
Copy link
Contributor Author

ajhunyady commented Sep 5, 2024

@diogopontual this PR will send you all over the code base. Once you are done, you'll have a pretty good grip on how fluvio works 😉

@diogopontual
Copy link
Contributor

Sounds good! That sounds good! I hope to understand everything and create this PR quickly!

TY

@diogopontual
Copy link
Contributor

diogopontual commented Oct 4, 2024

Hey @ajhunyady, I'm sorry for the long delay. I had some issues with my previous job, and I was fixing them.

Well, I am back. Looking at the current description, more data fields are being printed:

Image

Should I remove some of them to make it similar to this issue description?

Thank you.

@EstebanBorai EstebanBorai changed the title [Enhancement]: Improve fluvio topic describe with additional information Improve fluvio topic describe with additional information Oct 4, 2024
@EstebanBorai
Copy link
Contributor

Im taking advantage of Type field as of the new issues API here!

Image

@ajhunyady
Copy link
Contributor Author

ajhunyady commented Oct 4, 2024

Hey @ajhunyady, I'm sorry for the long delay. I had some issues with my previous job, and I was fixing them.

Well, I am back. Looking at the current description, more data fields are being printed:

Image

Should I remove some of them to make it similar to this issue description?

Thank you.

Hi @diogopontual welcome back :)

It looks like I missed a few fields. I've edited the issue description to include the other parameters. I left out (ignore rack assignment).
Let me know if I missed anything relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI good first issue Good for newcomers help wanted Good issue for community involvement no-stale Opt-out of closing issue due to no activity
Projects
None yet
Development

No branches or pull requests

5 participants