fix: default url for telemetry should include protocol

closes: #25502
influxdata · Nov 4, 2024 · 921b2bc · 921b2bc
1 parent aa70a73
commit 921b2bc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/influxdb3/src/commands/serve.rs b/influxdb3/src/commands/serve.rs
@@ -267,7 +267,7 @@ pub struct Config {
     #[clap(
         long = "telemetry-endpoint",
         env = "INFLUXDB3_TELEMETRY_ENDPOINT",
-        default_value = "localhost",
+        default_value = "http://localhost",
         action
     )]
     pub telemetry_endpoint: String,

diff --git a/influxdb3_telemetry/src/sender.rs b/influxdb3_telemetry/src/sender.rs
@@ -132,6 +132,19 @@ mod tests {
         mock.assert_async().await;
     }
 
+    #[test_log::test(test)]
+    #[should_panic]
+    fn test_sender_creation_with_invalid_url_panics() {
+        let client = reqwest::Client::new();
+        let _ = TelemetrySender::new(client, "localhost");
+    }
+
+    #[test_log::test(test)]
+    fn test_sender_creation_with_valid_url_succeeds() {
+        let client = reqwest::Client::new();
+        let _ = TelemetrySender::new(client, "http://localhost");
+    }
+
     #[test]
     fn test_url_join() {
         let url = Url::parse("https://foo.com/boo/1.html").unwrap();