Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track metrics for time to persist files #25612

Open
hiltontj opened this issue Dec 3, 2024 · 0 comments
Open

Track metrics for time to persist files #25612

hiltontj opened this issue Dec 3, 2024 · 0 comments
Labels

Comments

@hiltontj
Copy link
Contributor

hiltontj commented Dec 3, 2024

Problem statement

There are several places where we persist files to object store, and we have no way of tracking how much time is spent doing so.

Proposed solution

Add metrics to track time to persist files in the following places:

  • Catalog persistence (see here)
  • Snapshot persistence (see here)
  • Parquet persistence (see here)
  • WAL file persistence (see here)

Note that some of these are done in a loop, so the time to persist should track from when the loop starts to when the file was successfully persisted.

Alternatives considered

N/A

Additional context

The metric crate in core provides the means to track times like these via a DurationHistogram metric.

@hiltontj hiltontj added the v3 label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant