Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets not removed if pod fails admission #144

Open
jmickey opened this issue Jun 24, 2024 · 0 comments
Open

Secrets not removed if pod fails admission #144

jmickey opened this issue Jun 24, 2024 · 0 comments

Comments

@jmickey
Copy link

jmickey commented Jun 24, 2024

If a pod fails admission for some reason (e.g. another webhook, mutating or validating, fails) after the telegraf-operator has processed the pod then the resulting secret is not automatically removed.

Unless you're explicitly monitoring and alarming on the number of secret objects in the cluster this can quckly become a problem, for example if a rouge deployment attempting to constantly scale but failing on ValidatingAdmissionWebhooks, eventually causing API server issues if the number of secret objects grows excessively large.

What products and version are you using?

Kubernetes: 1.28
Telegraf-operator: 1.3.11

Additional Comments

It appears this project is no longer being updated or maintained, which is unfortunate as it solves an inherent problem with using influxdb and telegraf to monitor applications in Kubernetes.

As such I decided to completely re-write the project from scratch, resolving this issue, and others such as #137. The project can be found at https://github.com/jmickey/telegraf-sidecar-operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant