Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unfurling for better site previews of INFO Tech Radar #14

Open
edgarvonk opened this issue Mar 8, 2023 · 2 comments
Open

Improve unfurling for better site previews of INFO Tech Radar #14

edgarvonk opened this issue Mar 8, 2023 · 2 comments

Comments

@edgarvonk
Copy link
Member

Our https://infonl.github.io/info-techradar/index.html does not show a nice preview in Slack (nor probably elsewhere).

See https://medium.com/slack-developer-blog/everything-you-ever-wanted-to-know-about-unfurling-but-were-afraid-to-ask-or-how-to-make-your-e64b4bb9254 for details on how to improve this.

Screenshot 2023-03-08 at 10 09 43

@edgarvonk
Copy link
Member Author

Overriding the publlic/index.html file as per documentation does not work. The file just gets copied to /build but not processed at all. E.g. it ends up with content like

<link rel="stylesheet" href="%PUBLIC_URL%/fonts.css">

But also the JS links are not being added at all.

It seems this is due to: AOEpeople/aoe_technology_radar#190 . Although it is closed I don't think it has been solved. Might be related to: AOEpeople/aoe_technology_radar#327 as well (which they are working on).

@snipem
Copy link

snipem commented May 5, 2023

AOEpeople/aoe_technology_radar#371 may fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants