Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to cometbft-rs #3820

Open
5 tasks
mzabaluev opened this issue Jan 29, 2024 · 0 comments · May be fixed by #3865
Open
5 tasks

Adapt to cometbft-rs #3820

mzabaluev opened this issue Jan 29, 2024 · 0 comments · May be fixed by #3865
Assignees
Labels
A: non-critical Admin: non-critical or less important I: dependencies Internal: related to dependencies

Comments

@mzabaluev
Copy link
Contributor

Summary

Replace usage of tendermint-rs with cometbft-rs.

Problem Definition

Tendermint-rs is in maintenance mode while new development, particularly support for CometBFT 1.0, is now in cometbft-rs.

Another concern is that the changes done in cometbft-rs currently lack validation by a real-world project, and Hermes is a prime candidate for such a project.

Proposal

Replace dependencies on tendermint-rs crates with the corresponding crates of cometbft-rs. The changes will be mostly trivial: renaming crate imports, module paths, some type names. For side-by-side support of multiple CometBFT proto versions, the modules to use from cometbft-proto would be less straightforward, but there will be less duplication with the new proto-originated versioning of the message types.

Acceptance Criteria

No tendermint* crates in Hermes' dependency tree, replaced with cometbft*.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: non-critical Admin: non-critical or less important I: dependencies Internal: related to dependencies
Projects
Status: 🩹 Triage
Development

Successfully merging a pull request may close this issue.

2 participants