Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple connection hops in tx chan-open-confirm #4055

Closed
5 of 10 tasks
Tracked by #3940
, #4058
...
joaotav opened this issue Jun 21, 2024 · 1 comment · Fixed by #4058
Closed
5 of 10 tasks
Tracked by #3940
, #4058
...

Add support for multiple connection hops in tx chan-open-confirm #4055

joaotav opened this issue Jun 21, 2024 · 1 comment · Fixed by #4058
Assignees
@joaotav
Labels
O: multi-hop Related to ICS 033 Multi-Hop Channel

Comments

@joaotav
Copy link
Collaborator

joaotav commented Jun 21, 2024 •
edited
Loading

Part of: #3940

Summary

tx chan-open-confirm

  • Replace call to tx_chan_cmd! macro with an inline function on TxChanOpenConfirmCmd
  • Add build_multihop_chan_open_confirm() to method build_chan_open_confirm_and_send() to enable the construction of MsgChannelOpenConfirm messages when multiple connection hops have been specified.

Tests

  • Manual testing for single-hop channel handshake
  • Manual testing for multihop channel handshake with 2 connection hops
  • Manual testing for multihop channel handshake with 2+ connection hops

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@joaotav joaotav added the O: multi-hop Related to ICS 033 Multi-Hop Channel label Jun 21, 2024
@joaotav joaotav self-assigned this Jun 21, 2024
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jun 21, 2024
@romac romac mentioned this issue Jun 21, 2024
Open
39 tasks
@joaotav joaotav mentioned this issue Jun 21, 2024
Merged
8 tasks
@joaotav joaotav linked a pull request Jun 21, 2024 that will close this issue
Add support for multiple connection hops in tx chan-open-confirm #4058
Merged
8 tasks
@joaotav
Copy link
Collaborator Author

joaotav commented Jun 24, 2024

Closed on #4058.

@joaotav joaotav closed this as completed Jun 24, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaotav joaotav

Labels
O: multi-hop Related to ICS 033 Multi-Hop Channel
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for multiple connection hops in tx chan-open-confirm informalsystems/hermes
1 participant
@joaotav