Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include compiled binaries in releases #1529

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Oct 10, 2024

Closes #1461

  • Tests added for any new code
  • Documentation added for any new functionality
  • Entries added to the respective CHANGELOG.md for any new functionality
  • Feature table on README.md updated for any listed functionality

@rnbguy rnbguy marked this pull request as ready for review October 10, 2024 22:37
@rnbguy
Copy link
Member Author

rnbguy commented Oct 12, 2024

I wonder why this workflow doesn't have a write permission and yet softprops/action-gh-release can make a release. Are we using a PAT ? If yes, we should use automatic token authentication instead.

@rnbguy rnbguy requested a review from bugarela October 12, 2024 07:16
@bugarela
Copy link
Collaborator

This is so cool! Thanks for putting it together.

Do you have any suggestions on how to merge/test this? Is there some way to manually trigger he binary release for the latest release, or should I try it only on the next release (and then I suppose it will magically work as this workflow is triggered when I push a new tag)?

@rnbguy
Copy link
Member Author

rnbguy commented Nov 30, 2024

It appears like the latest deno >=2.1.0 broke something.

denoland/deno#27172

Need to wait until it's resolved or pin the deno version to 2.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno binary builds in releases
2 participants