Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make errors idiomatic #307

Open
MikkelPaulson opened this issue Feb 19, 2023 · 0 comments
Open

Make errors idiomatic #307

MikkelPaulson opened this issue Feb 19, 2023 · 0 comments

Comments

@MikkelPaulson
Copy link
Collaborator

Rust errors:

  • Should be enums
  • Should implement the Error trait
  • Should implement Display

Most of the errors in the project, including the user-facing errors, satisfy none of these constraints. Refactor the various Result types, particularly the awkward and pervasive Result<T, Cow<str, 'static>>, to use proper enums that can bundle debugging information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant