Update to support GraphQL Search API #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, @coj337 nice work! I was dreading working on this, to be honest. Thanks so much for sharing your knowledge and fixing this. I will try to test/review in the next couple days. |
|
I'm going to merge into a new branch in my project so I can work on the unit test changes before going into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GraphQL API has some pretty major structural differences but it does the job and supports up to 50 results at once 🥳
Other than the query limit, I kept the other search functionality as identical as possible but I'm sus that LinkedIn doesn't have the same 1k result limit (I ran out of time to test that bit properly).