Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass options object to Spinner.runCommand #40

Open
codespool opened this issue Nov 19, 2022 · 0 comments
Open

Pass options object to Spinner.runCommand #40

codespool opened this issue Nov 19, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@codespool
Copy link
Collaborator

This fix:
#24
has caused some undesired behaviour (init command exits if yarn install fails, and doesn't create config file), so an additional param shouldExitOnError was added.

Since there are a lot of optional params, it makes sense to put those together into a single options param.
@codespool codespool added enhancement New feature or request good first issue Good for newcomers labels Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codespool