This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Add deadline on consumer to send non-empty record batch #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racevedoo
suggested changes
Apr 23, 2021
ggml1
force-pushed
the
batch-production-deadline
branch
from
7a872fd
to
d5d3617
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added a deadline for the consumer to flush non-empty batches to the storage service, which defaults to one minute without receiving new records.
This deadline is also configurable through the environment variable
KAFKA_CONSUMER_BATCH_DEADLINE.For the flush logic to be reusable in both select cases, I have split the send logic in a separate function.
Note: I had to run
go mod tidyand import some packages again, because some dependencies were broken and I was unable to test or build in my local environment.Why is this PR needed?
Closes #8.
Checklist
feature/*,fix/*,hotfix/*)