Replies: 1 comment
-
That's awesome @piyushrpt!!! Having a pure python version would be so much simpler. For an more comprehensive testing, I would think letting the two versions of code generate several global solid Earth tides time series of several years long, crossing a few dacades, in coarse grid, would be ensuring enough to believe the two are behaving consistently. As for the comparison, either of the 3 sounds good to me. Once all the tests/comparisons passed, we could replace the current version with the new one in this same original repo. I have given your account the manager permission, and please do not hesitate to let me know if more is needed. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is related to isce-framework/isce3#22
@yunjunz @hfattahi
Currently,
pysolid
is the only dependency forisce3
that requires us to install a Fortran compiler to build from source. It would be great if this dependence onFortran
can be eliminated.I did a brute force translation to python and fiddled with the code a bit to give it some structure while retaining variable names, and have a reasonably working python implementation. By working, I mean it passes the tests that are currently in this repo. We would want to test this more extensively to convince ourselves that this is a reasonable replacement. The computations are fairly straightforward and I don't think performance will be an issue.
How would we go about this comparison?
Add a folder called
pyimpl
inpysolid
and for the test scripts just usefrom pysolid.pyimpl import point, grid
. This allows for code to be in same repo and for comparisons.Create a new repo called
pysolid2
and scripts can useimport pysolid2 as pysolid
for the tests.Drop the code into
isce3.solid_earth_tides
and scripts can usefrom isce3.solid_earth_tides import pysolid
Beta Was this translation helpful? Give feedback.
All reactions