Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tooltip to arbitrary lines UI #111

Closed
kpagacz opened this issue Jan 24, 2022 · 2 comments · Fixed by #211
Closed

Add a tooltip to arbitrary lines UI #111

kpagacz opened this issue Jan 24, 2022 · 2 comments · Fixed by #211
Assignees
@asbates
Labels
core enhancement New feature or request

Comments

@kpagacz
Copy link
Contributor

kpagacz commented Jan 24, 2022

image
Env: https://rsconnect.roche.com/connect/#/apps/7204/access

There's no way to know that multiple lines can be drawn on the plot by writing multiple comma-separated values. Would be nice to have a small indication of how to achieve this.
@kpagacz kpagacz added enhancement New feature or request core labels Jan 24, 2022
@gogonzo
Copy link
Contributor

gogonzo commented Mar 29, 2022

To consider alternative:
#85

@kpagacz kpagacz mentioned this issue Apr 4, 2022
Closed
@asbates asbates self-assigned this Dec 5, 2022
@asbates
Copy link
Contributor

asbates commented Dec 5, 2022

To consider alternative: #85

@gogonzo I think #85 is bigger than this issue. I think we should add the tooltip now since it's quick, and handle 85 separately

This was referenced Dec 5, 2022
Merged
Open
asbates added a commit that referenced this issue Dec 14, 2022
@asbates
Add tooltip to arbitrary lines UI (#211)
de5d8dc 
* Adds an explanatory tooltip for 'Value' input in arbitrary lines UI.
* To do this, adds new function `with_tooltip`

Fixes #111


Co-authored-by: Nikolas Burkoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asbates asbates

Labels
core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tooltip to arbitrary lines UI insightsengineering/teal.goshawk
3 participants
@gogonzo @kpagacz @asbates