Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace axes checkbox #129

Closed
wants to merge 2 commits into from
Closed

replace axes checkbox #129

wants to merge 2 commits into from

Conversation

denisovan31415
Copy link
Contributor

closes #128

Screen Shot 2022-03-08 at 10 38 17 PM

@denisovan31415 denisovan31415 added the enhancement New feature or request label Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022 •
edited
Loading

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        303     303  0.00%    223-582
R/tm_g_gh_correlationplot.R                510     510  0.00%    286-897
R/tm_g_gh_density_distribution_plot.R      235     235  0.00%    163-439
R/tm_g_gh_lineplot.R                       493     493  0.00%    183-759
R/tm_g_gh_scatterplot.R                    188     188  0.00%    163-397
R/tm_g_gh_spaghettiplot.R                  216     216  0.00%    230-494
R/toggleable_slider.R                      141     141  0.00%    82-239
R/utils.R                                  312     312  0.00%    2-500
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2399    2399  0.00%

Results for commit: f4ee718

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@denisovan31415 denisovan31415 requested a review from npaszty March 9, 2022 16:22
@gogonzo gogonzo self-assigned this Mar 11, 2022
gogonzo
gogonzo requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use + scale_x_continuous directly here

insightsengineering/goshawk#116

@denisovan31415
Copy link
Contributor Author

@npaszty closing this ticket as discussed with @gogonzo.
issue needs to be moved to backlog to be refined and discussed.

@gogonzo gogonzo deleted the #128_checkbox@main branch April 11, 2022 05:25
@gogonzo gogonzo self-assigned this May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogonzo gogonzo gogonzo requested changes

@npaszty npaszty Awaiting requested review from npaszty

Assignees

@gogonzo gogonzo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox UI to replace entire axes values with hori / vert value labels
2 participants
@denisovan31415 @gogonzo