Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a data_constraint_module #204

Open
gogonzo opened this issue Nov 4, 2022 · 0 comments
Open

Make a data_constraint_module #204

gogonzo opened this issue Nov 4, 2022 · 0 comments
Labels
core refactor

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Nov 4, 2022

Change constr_anl_q, keep_constr_opts_updated and create_anl_constraint_reactive to one shiny module data_constraint_ui/srv
Make sure that:

  • Selecting biomarker affects radio buttons to select constraints. Only constraints which don't have all missings in data
  • Selecting constraint should show/hide range input to select constraint-range
  • module should accept and return qenv or accept data and return expression
  • Try to avoid using hardcoded column names (like PARAMCD), they should be taken from the module arguments
  • Make universal so that it could be applied to tm_correlation_plot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gogonzo