You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
seems that there is a validation that the analysis variable has to be PARAMCD but PARAM would work equally well. Can PARAM be added to the validation so that it too is acceptable as this argument? param_var = "PARAM"?
If above is acceptable then we need to deal with the menu item sorting. currently the sort looks like a regular case sensitive sort by ASCII collating sequence so upper case sorts first then lower case. but what we want is a case insensitive sort like in the following example
Follow up: we encountered some challenges when we tried make the interface more user-friendly for Biomarker plots created by functions like tm_g_gh_boxplot, tm_g_gh_correlationplot, and so on.
Motivation: currently displayed choices in "Select a Biomarker" start with PARAMCD (like "A0000A") but our users are not familiar with them. We want to replace them with what the users are more familiar with: PARAM (like "Something_a_biomarker"). Ideally, PARAMCD should not appear in the choices.
First we passed a different list to param argument in the plotting functions; this list is built solely from PARAM column. But the functions failed to recognize datapoints correctly (and no plot created), possible due to mismatch between param_var and param.
Second, we passed PARAM to param_var, hopping to resolve the mismatch, but instead we triggered this error:
stop("param_var must be 'PARAMCD'. Otherwise, we cannot currently guarantee the correctness of the code.")
It appears that the function's current design limits its flexibility. Ideally, the argument param_var should accept columns other than PARAMCD without losing the ability to identify and use datapoints
we did also try to "subvert the system" by renaming PARAM <- PARAMCD and PARAMCD <- PARAM which did "work" but this kludge isn't really getting at the root cause.
Feature description
Code of Conduct
Contribution Guidelines
Security Policy
The text was updated successfully, but these errors were encountered: