Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on coverage workflow #745

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Fix error on coverage workflow #745

merged 4 commits into from
Apr 26, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Apr 24, 2024

Pull Request

Fixes #746

{covr} doesn't have access to the man page anywhere in the file structure.

The symlink of man on the testthat folder triggers a full copy during {covr}. This is a promising approach, however, I cannot observe that the tests are being run and needs further investigation.

Changes description

  • use testthat::skip instead of stop when there is a problem
  • TESTING_DEPTH is not yet set to 5 on this CI, therefore the shinytest2 tests are not being run.
  • Keep symlink to support testing examples during examples in the future

Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              678     416  38.64%   303-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               357     357  0.00%    154-584
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1075    1075  0.00%    92-1323
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8792    8492  3.41%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: b980d7b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   22 suites   10m 30s ⏱️
147 tests 147 ✅ 0 💤 0 ❌
478 runs  478 ✅ 0 💤 0 ❌

Results for commit b980d7b.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_outliers 💚 $84.94$ $-2.00$ $0$ $0$ $0$ $0$

Results for commit 272ddef

♻️ This comment has been updated with latest results.

Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@averissimo averissimo merged commit 024e388 into main Apr 26, 2024
21 checks passed
@averissimo averissimo deleted the fix-covr-workflow@main branch April 26, 2024 12:45
@pawelru
Copy link
Contributor

pawelru commented May 2, 2024

Hi guys. Thanks for fixing this. Would you be able to sync examples testing in tmc with the recent changes to it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Coverage CI has a failing test
3 participants