Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added checks to resolve issue with the outlier function #778

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

PritDash
Copy link
Contributor

@PritDash PritDash commented Aug 28, 2024

Pull Request

Fixes #768

The reproducible example is in the linked issue.

Issue:

The outlier package threw the following error when trying to add a card:

Warning in observe() :
  The card could not be added to the report. Have the outputs for the report been created yet? If not please try again when they are ready. Otherwise contact your application developer
Error : Can't subset columns that don't exist.
✖ Column `order` doesn't exist. 
 when evaluating qenv code:
ANL_OUTLIER_EXTENDED[ANL_OUTLIER_EXTENDED$is_outlier_selected, columns_index]

Solution:

removed order column as it cannot be in the ANL_OUTLIER_EXTENDED dataframe

setdiff(names(ANL_OUTLIER), c("is_outlier_selected", "order"))

Copy link
Contributor

github-actions bot commented Aug 28, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@PritDash
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@PritDash
Copy link
Contributor Author

PritDash commented Sep 5, 2024

Please review my PR as it is ready. @m7pr @gogonzo

@PritDash PritDash marked this pull request as ready for review September 5, 2024 13:44
@Polkas
Copy link
Contributor

Polkas commented Sep 5, 2024

We found the same issue and it is a blocker for us. Thus so we proposed an update:)

@m7pr
Copy link
Contributor

m7pr commented Sep 12, 2024

Hey, sorry, I was off last week and didn't see the notification. I will review in the morning

@donyunardi donyunardi self-assigned this Sep 12, 2024
Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks you @PritDash !

@donyunardi donyunardi merged commit 2327679 into insightsengineering:main Sep 13, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants