From 4fb413ca2ec8ef5955059ba21beede0dc3e70a88 Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 22 Apr 2024 17:49:31 +0530 Subject: [PATCH 1/6] adding title case in test description --- tests/testthat/test-shinytest2-tm_a_pca.R | 2 +- .../test-shinytest2-tm_a_regression.R | 14 ++++++------- .../test-shinytest2-tm_g_association.R | 8 ++++---- .../testthat/test-shinytest2-tm_g_bivariate.R | 8 ++++---- .../test-shinytest2-tm_g_distribution.R | 6 +++--- .../test-shinytest2-tm_g_scatterplot.R | 10 +++++----- tests/testthat/test-shinytest2-tm_outliers.R | 20 +++++++++---------- .../test-shinytest2-tm_variable_browser.R | 10 +++++----- 8 files changed, 39 insertions(+), 39 deletions(-) diff --git a/tests/testthat/test-shinytest2-tm_a_pca.R b/tests/testthat/test-shinytest2-tm_a_pca.R index 8752a0ca9..c596f7151 100644 --- a/tests/testthat/test-shinytest2-tm_a_pca.R +++ b/tests/testthat/test-shinytest2-tm_a_pca.R @@ -35,7 +35,7 @@ app_driver_tm_a_pca <- function() { # Defaults -------------------------------------------------------------------- -testthat::test_that("e2e - tm_a_pca: module is initialised with the specified defaults in function call", { +testthat::test_that("e2e - tm_a_pca: Module is initialised with the specified defaults in function call", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() diff --git a/tests/testthat/test-shinytest2-tm_a_regression.R b/tests/testthat/test-shinytest2-tm_a_regression.R index 1379a2711..a2e87709a 100644 --- a/tests/testthat/test-shinytest2-tm_a_regression.R +++ b/tests/testthat/test-shinytest2-tm_a_regression.R @@ -46,7 +46,7 @@ app_driver_tm_a_regression <- function() { ) } -testthat::test_that("e2e - tm_a_regression: data parameter and module label is passed properly", { +testthat::test_that("e2e - tm_a_regression: Data parameter and module label is passed properly", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -64,7 +64,7 @@ testthat::test_that("e2e - tm_a_regression: data parameter and module label is p }) testthat::test_that("e2e - tm_a_regression: - data extract spec elements are initialized with the default values specified by response and regressor arg", { + Data extract spec elements are initialized with the default values specified by response and regressor arg", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -82,7 +82,7 @@ testthat::test_that("e2e - tm_a_regression: app_driver$stop() }) -testthat::test_that("e2e - tm_a_regression: plot_type is set properly", { +testthat::test_that("e2e - tm_a_regression: Plot type is set properly", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -95,7 +95,7 @@ testthat::test_that("e2e - tm_a_regression: plot_type is set properly", { }) testthat::test_that("e2e - tm_a_regression: - plot type has 7 specific choices & changing choices does not throw errors", { + Plot type has 7 specific choices & changing choices does not throw errors", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -122,7 +122,7 @@ testthat::test_that("e2e - tm_a_regression: app_driver$stop() }) -testthat::test_that("e2e - tm_a_regression: outlier definition and label are visible by default", { +testthat::test_that("e2e - tm_a_regression: Outlier definition and label are visible by default", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -134,7 +134,7 @@ testthat::test_that("e2e - tm_a_regression: outlier definition and label are vis app_driver$stop() }) -testthat::test_that("e2e - tm_a_regression: outlier definition and label have default values and label text", { +testthat::test_that("e2e - tm_a_regression: Outlier definition and label have default values and label text", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -162,7 +162,7 @@ testthat::test_that("e2e - tm_a_regression: outlier definition and label have de app_driver$stop() }) -testthat::test_that("e2e - tm_a_regression: unchecking display outlier hides outlier label and definition", { +testthat::test_that("e2e - tm_a_regression: Unchecking display outlier hides outlier label and definition", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() diff --git a/tests/testthat/test-shinytest2-tm_g_association.R b/tests/testthat/test-shinytest2-tm_g_association.R index 562942770..ee8837e24 100644 --- a/tests/testthat/test-shinytest2-tm_g_association.R +++ b/tests/testthat/test-shinytest2-tm_g_association.R @@ -45,7 +45,7 @@ app_driver_tm_g_association <- function() { ) } -testthat::test_that("e2e - tm_g_association: data parameter and module label is passed properly", { +testthat::test_that("e2e - tm_g_association: Data parameter and module label is passed properly", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_association() @@ -63,7 +63,7 @@ testthat::test_that("e2e - tm_g_association: data parameter and module label is }) testthat::test_that("e2e - tm_g_association: - data extract spec elements are initialized with the default values specified by ref and vars arguments", { + Data extract spec elements are initialized with the default values specified by ref and vars arguments", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_association() @@ -83,7 +83,7 @@ testthat::test_that("e2e - tm_g_association: app_driver$stop() }) -testthat::test_that("e2e - tm_g_association: module plot is visible", { +testthat::test_that("e2e - tm_g_association: Module plot is visible", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_association() @@ -93,7 +93,7 @@ testthat::test_that("e2e - tm_g_association: module plot is visible", { }) -testthat::test_that("e2e - tm_g_association: test if default radio buttons are checked", { +testthat::test_that("e2e - tm_g_association: Check and set default values for radio buttons", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_association() diff --git a/tests/testthat/test-shinytest2-tm_g_bivariate.R b/tests/testthat/test-shinytest2-tm_g_bivariate.R index 39ad6e1cb..f9d105c26 100644 --- a/tests/testthat/test-shinytest2-tm_g_bivariate.R +++ b/tests/testthat/test-shinytest2-tm_g_bivariate.R @@ -85,7 +85,7 @@ app_driver_tm_g_bivariate <- function() { ) } -testthat::test_that("e2e - tm_g_bivariate: module is initialised with the specified defaults", { +testthat::test_that("e2e - tm_g_bivariate: Module is initialised with the specified defaults", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_bivariate() @@ -113,7 +113,7 @@ testthat::test_that("e2e - tm_g_bivariate: module is initialised with the specif app_driver$stop() }) -testthat::test_that("e2e - tm_g_bivariate: coloring options are hidden when coloring is toggled off", { +testthat::test_that("e2e - tm_g_bivariate: Coloring options are hidden when coloring is toggled off", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_bivariate() @@ -154,7 +154,7 @@ testthat::test_that("e2e - tm_g_bivariate: coloring options are hidden when colo app_driver$stop() }) -testthat::test_that("e2e - tm_g_bivariate: facetting options are hidden when facet is toggled off", { +testthat::test_that("e2e - tm_g_bivariate: Facetting options are hidden when facet is toggled off", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_bivariate() @@ -190,7 +190,7 @@ testthat::test_that("e2e - tm_g_bivariate: facetting options are hidden when fac app_driver$stop() }) -testthat::test_that("e2e - tm_g_bivariate: setting encoding inputs produces outputs without validation errors", { +testthat::test_that("e2e - tm_g_bivariate: Setting encoding inputs produces outputs without validation errors", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_bivariate() diff --git a/tests/testthat/test-shinytest2-tm_g_distribution.R b/tests/testthat/test-shinytest2-tm_g_distribution.R index 49f447065..57f0d5ed9 100644 --- a/tests/testthat/test-shinytest2-tm_g_distribution.R +++ b/tests/testthat/test-shinytest2-tm_g_distribution.R @@ -47,7 +47,7 @@ app_driver_tm_g_distribution <- function() { ) } -testthat::test_that("e2e - tm_g_distribution: module is initialised with the specified defaults", { +testthat::test_that("e2e - tm_g_distribution: Module is initialised with the specified defaults", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_distribution() @@ -71,7 +71,7 @@ testthat::test_that("e2e - tm_g_distribution: module is initialised with the spe app_driver$stop() }) -testthat::test_that("e2e - tm_g_distribution: histogram encoding inputs produce output without validation errors", { +testthat::test_that("e2e - tm_g_distribution: Histogram encoding inputs produce output without validation errors", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_distribution() @@ -108,7 +108,7 @@ testthat::test_that("e2e - tm_g_distribution: histogram encoding inputs produce app_driver$stop() }) -testthat::test_that("e2e - tm_g_distribution: qqplot encoding inputs produce output without validation errors", { +testthat::test_that("e2e - tm_g_distribution: QQ plot encoding inputs produce output without validation errors", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_distribution() diff --git a/tests/testthat/test-shinytest2-tm_g_scatterplot.R b/tests/testthat/test-shinytest2-tm_g_scatterplot.R index 9b74efd08..3400ca983 100644 --- a/tests/testthat/test-shinytest2-tm_g_scatterplot.R +++ b/tests/testthat/test-shinytest2-tm_g_scatterplot.R @@ -84,7 +84,7 @@ app_driver_tm_g_scatterplot <- function() { ) } -testthat::test_that("e2e - tm_g_scatterplot: module is initialised with the specified defaults", { +testthat::test_that("e2e - tm_g_scatterplot: Module is initialised with the specified defaults", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() @@ -110,7 +110,7 @@ testthat::test_that("e2e - tm_g_scatterplot: module is initialised with the spec app$stop() }) -testthat::test_that("e2e - tm_g_scatterplot: base for the log transformation can be applied", { +testthat::test_that("e2e - tm_g_scatterplot: Base for the log transformation can be applied", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() @@ -130,7 +130,7 @@ testthat::test_that("e2e - tm_g_scatterplot: base for the log transformation can app$stop() }) -testthat::test_that("e2e - tm_g_scatterplot: log transform is only possible for positive numeric vars", { +testthat::test_that("e2e - tm_g_scatterplot: The log transform is only possible for positive numeric vars", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() @@ -149,7 +149,7 @@ testthat::test_that("e2e - tm_g_scatterplot: log transform is only possible for app$stop() }) -testthat::test_that("e2e - tm_g_scatterplot: get validation error when facetting with the same row & col variable", { +testthat::test_that("e2e - tm_g_scatterplot: Get validation error when facetting with the same row & col variable", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() @@ -161,7 +161,7 @@ testthat::test_that("e2e - tm_g_scatterplot: get validation error when facetting app$stop() }) -testthat::test_that("e2e - tm_g_scatterplot: encoding inputs produce output without validation errors", { +testthat::test_that("e2e - tm_g_scatterplot: The encoding inputs produce output without validation errors", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() diff --git a/tests/testthat/test-shinytest2-tm_outliers.R b/tests/testthat/test-shinytest2-tm_outliers.R index 49065a963..564dc74e2 100644 --- a/tests/testthat/test-shinytest2-tm_outliers.R +++ b/tests/testthat/test-shinytest2-tm_outliers.R @@ -49,7 +49,7 @@ app_driver_tm_outlier <- function() { ) } -testthat::test_that("e2e - tm_outliers: data parameter and module label is passed properly", { +testthat::test_that("e2e - tm_outliers: Data parameter and module label is passed properly", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -68,7 +68,7 @@ testthat::test_that("e2e - tm_outliers: data parameter and module label is passe }) testthat::test_that("e2e - tm_outliers: - data extract spec elements are initialized with the default values + Data extract spec elements are initialized with the default values specified by outlier_var and categorical_var argument", { skip_if_too_deep(5) @@ -105,7 +105,7 @@ testthat::test_that("e2e - tm_outliers: app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: default plot_type is set properly and has proper possible choices", { +testthat::test_that("e2e - tm_outliers: Plot type is correctly set by default and has appropriate possible options", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -122,7 +122,7 @@ testthat::test_that("e2e - tm_outliers: default plot_type is set properly and ha app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: module is divided into 3 tabs", { +testthat::test_that("e2e - tm_outliers: Module is divided into 3 tabs", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -137,7 +137,7 @@ testthat::test_that("e2e - tm_outliers: module is divided into 3 tabs", { app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: plot_type is hidden when Boxplot tab is not selected", { +testthat::test_that("e2e - tm_outliers: Plot type is hidden when Boxplot tab is not selected", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -154,7 +154,7 @@ testthat::test_that("e2e - tm_outliers: plot_type is hidden when Boxplot tab is app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: default radio buttons are set properly", { +testthat::test_that("e2e - tm_outliers: Default radio buttons are set properly", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -170,7 +170,7 @@ testthat::test_that("e2e - tm_outliers: default radio buttons are set properly", app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: method parameters are set properly", { +testthat::test_that("e2e - tm_outliers: Method parameters are set properly", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -185,7 +185,7 @@ testthat::test_that("e2e - tm_outliers: method parameters are set properly", { }) -testthat::test_that("e2e - tm_outliers: outlier definition text and range are displayed properly depending on method", { +testthat::test_that("e2e - tm_outliers: Outlier definition text and range are displayed properly depending on method", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -236,7 +236,7 @@ testthat::test_that("e2e - tm_outliers: outlier definition text and range are di app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: outliers summary table is displayed with proper content", { +testthat::test_that("e2e - tm_outliers: Outliers summary table is displayed with proper content", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -285,7 +285,7 @@ testthat::test_that("e2e - tm_outliers: outliers summary table is displayed with }) -testthat::test_that("e2e - tm_outliers: outlier table is displayed with proper content", { +testthat::test_that("e2e - tm_outliers: Outlier table is displayed with proper content", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() diff --git a/tests/testthat/test-shinytest2-tm_variable_browser.R b/tests/testthat/test-shinytest2-tm_variable_browser.R index c78646e9d..c270c9d8a 100644 --- a/tests/testthat/test-shinytest2-tm_variable_browser.R +++ b/tests/testthat/test-shinytest2-tm_variable_browser.R @@ -26,7 +26,7 @@ app_driver_tm_variable_browser <- function() { ) } -testthat::test_that("e2e - tm_variable_browser: content is displayed correctly", { +testthat::test_that("e2e - tm_variable_browser: Content is displayed correctly", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -94,7 +94,7 @@ testthat::test_that("e2e - tm_variable_browser: Selecting 'treat variable as fac }) -testthat::test_that("e2e - tm_variable_browser: selection of categorical variable has a table with 'level' header", { +testthat::test_that("e2e - tm_variable_browser: Selection of categorical variable has a table with 'level' header", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -149,7 +149,7 @@ testthat::test_that("e2e - tm_variable_browser: selection of categorical variabl }) -testthat::test_that("e2e - tm_variable_browser: changing 'display density' encoding doesn't show errors", { +testthat::test_that("e2e - tm_variable_browser: Changing 'display density' encoding doesn't show errors", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -164,7 +164,7 @@ testthat::test_that("e2e - tm_variable_browser: changing 'display density' encod app_driver$stop() }) -testthat::test_that("e2e - tm_variable_browser: changing 'outlier definition' encoding doesn't show errors", { +testthat::test_that("e2e - tm_variable_browser: Changing 'outlier definition' encoding doesn't show errors", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -191,7 +191,7 @@ testthat::test_that("e2e - tm_variable_browser: changing 'outlier definition' en app_driver$stop() }) -testthat::test_that("e2e - tm_variable_browser: changing plot setting encodings doesn't show errors", { +testthat::test_that("e2e - tm_variable_browser: Changing plot setting encodings doesn't show errors", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() From 6201658cb6417cc97b22eb51627d97116655f616 Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 22 Apr 2024 20:38:35 +0530 Subject: [PATCH 2/6] adding full full stop --- .../test-shinytest2-tm_a_regression.R | 15 +++++++------ .../test-shinytest2-tm_g_association.R | 10 ++++----- .../testthat/test-shinytest2-tm_g_bivariate.R | 8 +++---- .../test-shinytest2-tm_g_distribution.R | 6 ++--- .../testthat/test-shinytest2-tm_g_response.R | 9 ++++---- .../test-shinytest2-tm_g_scatterplot.R | 10 ++++----- tests/testthat/test-shinytest2-tm_outliers.R | 22 +++++++++---------- .../test-shinytest2-tm_variable_browser.R | 14 +++++------- 8 files changed, 46 insertions(+), 48 deletions(-) diff --git a/tests/testthat/test-shinytest2-tm_a_regression.R b/tests/testthat/test-shinytest2-tm_a_regression.R index a2e87709a..a8e010b32 100644 --- a/tests/testthat/test-shinytest2-tm_a_regression.R +++ b/tests/testthat/test-shinytest2-tm_a_regression.R @@ -46,7 +46,7 @@ app_driver_tm_a_regression <- function() { ) } -testthat::test_that("e2e - tm_a_regression: Data parameter and module label is passed properly", { +testthat::test_that("e2e - tm_a_regression: Data parameter and module label is passed properly.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -64,7 +64,7 @@ testthat::test_that("e2e - tm_a_regression: Data parameter and module label is p }) testthat::test_that("e2e - tm_a_regression: - Data extract spec elements are initialized with the default values specified by response and regressor arg", { + Data extract spec elements are initialized with the default values specified by response and regressor arg.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -79,10 +79,11 @@ testthat::test_that("e2e - tm_a_regression: "conc" ) app_driver$set_active_module_input("regressor-dataset_CO2_singleextract-select", "Treatment") + app_driver$stop() }) -testthat::test_that("e2e - tm_a_regression: Plot type is set properly", { +testthat::test_that("e2e - tm_a_regression: Plot type is set properly.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -95,7 +96,7 @@ testthat::test_that("e2e - tm_a_regression: Plot type is set properly", { }) testthat::test_that("e2e - tm_a_regression: - Plot type has 7 specific choices & changing choices does not throw errors", { + Plot type has 7 specific choices & changing choices does not throw errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -122,7 +123,7 @@ testthat::test_that("e2e - tm_a_regression: app_driver$stop() }) -testthat::test_that("e2e - tm_a_regression: Outlier definition and label are visible by default", { +testthat::test_that("e2e - tm_a_regression: Outlier definition and label are visible by default.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -134,7 +135,7 @@ testthat::test_that("e2e - tm_a_regression: Outlier definition and label are vis app_driver$stop() }) -testthat::test_that("e2e - tm_a_regression: Outlier definition and label have default values and label text", { +testthat::test_that("e2e - tm_a_regression: Outlier definition and label have default values and label text.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() @@ -162,7 +163,7 @@ testthat::test_that("e2e - tm_a_regression: Outlier definition and label have de app_driver$stop() }) -testthat::test_that("e2e - tm_a_regression: Unchecking display outlier hides outlier label and definition", { +testthat::test_that("e2e - tm_a_regression: Unchecking display outlier hides outlier label and definition.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_regression() diff --git a/tests/testthat/test-shinytest2-tm_g_association.R b/tests/testthat/test-shinytest2-tm_g_association.R index ee8837e24..ac3c73401 100644 --- a/tests/testthat/test-shinytest2-tm_g_association.R +++ b/tests/testthat/test-shinytest2-tm_g_association.R @@ -45,7 +45,7 @@ app_driver_tm_g_association <- function() { ) } -testthat::test_that("e2e - tm_g_association: Data parameter and module label is passed properly", { +testthat::test_that("e2e - tm_g_association: Data parameter and module label is passed properly.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_association() @@ -63,7 +63,7 @@ testthat::test_that("e2e - tm_g_association: Data parameter and module label is }) testthat::test_that("e2e - tm_g_association: - Data extract spec elements are initialized with the default values specified by ref and vars arguments", { + Data extract spec elements are initialized with the default values specified by ref and vars arguments.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_association() @@ -83,7 +83,8 @@ testthat::test_that("e2e - tm_g_association: app_driver$stop() }) -testthat::test_that("e2e - tm_g_association: Module plot is visible", { + +testthat::test_that("e2e - tm_g_association: Module plot is visible.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_association() @@ -92,8 +93,7 @@ testthat::test_that("e2e - tm_g_association: Module plot is visible", { app_driver$stop() }) - -testthat::test_that("e2e - tm_g_association: Check and set default values for radio buttons", { +testthat::test_that("e2e - tm_g_association: Check and set default values for radio buttons.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_association() diff --git a/tests/testthat/test-shinytest2-tm_g_bivariate.R b/tests/testthat/test-shinytest2-tm_g_bivariate.R index f9d105c26..146f53a4f 100644 --- a/tests/testthat/test-shinytest2-tm_g_bivariate.R +++ b/tests/testthat/test-shinytest2-tm_g_bivariate.R @@ -85,7 +85,7 @@ app_driver_tm_g_bivariate <- function() { ) } -testthat::test_that("e2e - tm_g_bivariate: Module is initialised with the specified defaults", { +testthat::test_that("e2e - tm_g_bivariate: Module is initialised with the specified defaults.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_bivariate() @@ -113,7 +113,7 @@ testthat::test_that("e2e - tm_g_bivariate: Module is initialised with the specif app_driver$stop() }) -testthat::test_that("e2e - tm_g_bivariate: Coloring options are hidden when coloring is toggled off", { +testthat::test_that("e2e - tm_g_bivariate: Coloring options are hidden when coloring is toggled off.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_bivariate() @@ -154,7 +154,7 @@ testthat::test_that("e2e - tm_g_bivariate: Coloring options are hidden when colo app_driver$stop() }) -testthat::test_that("e2e - tm_g_bivariate: Facetting options are hidden when facet is toggled off", { +testthat::test_that("e2e - tm_g_bivariate: Facetting options are hidden when facet is toggled off.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_bivariate() @@ -190,7 +190,7 @@ testthat::test_that("e2e - tm_g_bivariate: Facetting options are hidden when fac app_driver$stop() }) -testthat::test_that("e2e - tm_g_bivariate: Setting encoding inputs produces outputs without validation errors", { +testthat::test_that("e2e - tm_g_bivariate: Setting encoding inputs produces outputs without validation errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_bivariate() diff --git a/tests/testthat/test-shinytest2-tm_g_distribution.R b/tests/testthat/test-shinytest2-tm_g_distribution.R index 57f0d5ed9..f65282719 100644 --- a/tests/testthat/test-shinytest2-tm_g_distribution.R +++ b/tests/testthat/test-shinytest2-tm_g_distribution.R @@ -47,7 +47,7 @@ app_driver_tm_g_distribution <- function() { ) } -testthat::test_that("e2e - tm_g_distribution: Module is initialised with the specified defaults", { +testthat::test_that("e2e - tm_g_distribution: Module is initialised with the specified defaults.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_distribution() @@ -71,7 +71,7 @@ testthat::test_that("e2e - tm_g_distribution: Module is initialised with the spe app_driver$stop() }) -testthat::test_that("e2e - tm_g_distribution: Histogram encoding inputs produce output without validation errors", { +testthat::test_that("e2e - tm_g_distribution: Histogram encoding inputs produce output without validation errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_distribution() @@ -108,7 +108,7 @@ testthat::test_that("e2e - tm_g_distribution: Histogram encoding inputs produce app_driver$stop() }) -testthat::test_that("e2e - tm_g_distribution: QQ plot encoding inputs produce output without validation errors", { +testthat::test_that("e2e - tm_g_distribution: QQ plot encoding inputs produce output without validation errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_distribution() diff --git a/tests/testthat/test-shinytest2-tm_g_response.R b/tests/testthat/test-shinytest2-tm_g_response.R index ab9da6557..0a8bf3f8d 100644 --- a/tests/testthat/test-shinytest2-tm_g_response.R +++ b/tests/testthat/test-shinytest2-tm_g_response.R @@ -40,7 +40,7 @@ app_driver_tm_g_response <- function() { ) } -testthat::test_that("e2e - tm_g_response: module is initialised with the specified defaults", { +testthat::test_that("e2e - tm_g_response: module is initialised with the specified defaults.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_response() @@ -57,7 +57,8 @@ testthat::test_that("e2e - tm_g_response: module is initialised with the specifi app_driver$stop() }) -testthat::test_that("e2e - tm_g_response: encoding inputs produce output without validation errors", { + +testthat::test_that("e2e - tm_g_response: encoding inputs produce output without validation errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_response() @@ -87,7 +88,7 @@ testthat::test_that("e2e - tm_g_response: encoding inputs produce output without app_driver$stop() }) -testthat::test_that("e2e - tm_g_response: deselecting response produces validation error", { +testthat::test_that("e2e - tm_g_response: deselecting response produces validation error.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_response() @@ -98,7 +99,7 @@ testthat::test_that("e2e - tm_g_response: deselecting response produces validati app_driver$stop() }) -testthat::test_that("e2e - tm_g_response: deselecting x produces validation error", { +testthat::test_that("e2e - tm_g_response: deselecting x produces validation error.", { skip_if_too_deep(5) app_driver <- app_driver_tm_g_response() diff --git a/tests/testthat/test-shinytest2-tm_g_scatterplot.R b/tests/testthat/test-shinytest2-tm_g_scatterplot.R index 3400ca983..09fd72a7b 100644 --- a/tests/testthat/test-shinytest2-tm_g_scatterplot.R +++ b/tests/testthat/test-shinytest2-tm_g_scatterplot.R @@ -84,7 +84,7 @@ app_driver_tm_g_scatterplot <- function() { ) } -testthat::test_that("e2e - tm_g_scatterplot: Module is initialised with the specified defaults", { +testthat::test_that("e2e - tm_g_scatterplot: Module is initialised with the specified defaults.", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() @@ -110,7 +110,7 @@ testthat::test_that("e2e - tm_g_scatterplot: Module is initialised with the spec app$stop() }) -testthat::test_that("e2e - tm_g_scatterplot: Base for the log transformation can be applied", { +testthat::test_that("e2e - tm_g_scatterplot: Base for the log transformation can be applied.", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() @@ -130,7 +130,7 @@ testthat::test_that("e2e - tm_g_scatterplot: Base for the log transformation can app$stop() }) -testthat::test_that("e2e - tm_g_scatterplot: The log transform is only possible for positive numeric vars", { +testthat::test_that("e2e - tm_g_scatterplot: The log transform is only possible for positive numeric vars.", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() @@ -149,7 +149,7 @@ testthat::test_that("e2e - tm_g_scatterplot: The log transform is only possible app$stop() }) -testthat::test_that("e2e - tm_g_scatterplot: Get validation error when facetting with the same row & col variable", { +testthat::test_that("e2e - tm_g_scatterplot: Get validation error when facetting with the same row & col variable.", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() @@ -161,7 +161,7 @@ testthat::test_that("e2e - tm_g_scatterplot: Get validation error when facetting app$stop() }) -testthat::test_that("e2e - tm_g_scatterplot: The encoding inputs produce output without validation errors", { +testthat::test_that("e2e - tm_g_scatterplot: The encoding inputs produce output without validation errors.", { skip_if_too_deep(5) app <- app_driver_tm_g_scatterplot() diff --git a/tests/testthat/test-shinytest2-tm_outliers.R b/tests/testthat/test-shinytest2-tm_outliers.R index 564dc74e2..fa9ad0acb 100644 --- a/tests/testthat/test-shinytest2-tm_outliers.R +++ b/tests/testthat/test-shinytest2-tm_outliers.R @@ -49,7 +49,7 @@ app_driver_tm_outlier <- function() { ) } -testthat::test_that("e2e - tm_outliers: Data parameter and module label is passed properly", { +testthat::test_that("e2e - tm_outliers: Data parameter and module label is passed properly.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -69,7 +69,7 @@ testthat::test_that("e2e - tm_outliers: Data parameter and module label is passe testthat::test_that("e2e - tm_outliers: Data extract spec elements are initialized with the default values - specified by outlier_var and categorical_var argument", { + specified by outlier_var and categorical_var argument.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -105,7 +105,7 @@ testthat::test_that("e2e - tm_outliers: app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: Plot type is correctly set by default and has appropriate possible options", { +testthat::test_that("e2e - tm_outliers: Plot type is correctly set by default and has appropriate possible options.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -122,7 +122,7 @@ testthat::test_that("e2e - tm_outliers: Plot type is correctly set by default an app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: Module is divided into 3 tabs", { +testthat::test_that("e2e - tm_outliers: Module is divided into 3 tabs.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -137,7 +137,7 @@ testthat::test_that("e2e - tm_outliers: Module is divided into 3 tabs", { app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: Plot type is hidden when Boxplot tab is not selected", { +testthat::test_that("e2e - tm_outliers: Plot type is hidden when Boxplot tab is not selected.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -154,7 +154,7 @@ testthat::test_that("e2e - tm_outliers: Plot type is hidden when Boxplot tab is app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: Default radio buttons are set properly", { +testthat::test_that("e2e - tm_outliers: Default radio buttons are set properly.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -170,7 +170,7 @@ testthat::test_that("e2e - tm_outliers: Default radio buttons are set properly", app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: Method parameters are set properly", { +testthat::test_that("e2e - tm_outliers: Method parameters are set properly.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -184,8 +184,7 @@ testthat::test_that("e2e - tm_outliers: Method parameters are set properly", { app_driver$stop() }) - -testthat::test_that("e2e - tm_outliers: Outlier definition text and range are displayed properly depending on method", { +testthat::test_that("e2e - tm_outliers: Outlier definition text and range are displayed properly depending on method.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -236,7 +235,7 @@ testthat::test_that("e2e - tm_outliers: Outlier definition text and range are di app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: Outliers summary table is displayed with proper content", { +testthat::test_that("e2e - tm_outliers: Outliers summary table is displayed with proper content.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() @@ -284,8 +283,7 @@ testthat::test_that("e2e - tm_outliers: Outliers summary table is displayed with app_driver$stop() }) - -testthat::test_that("e2e - tm_outliers: Outlier table is displayed with proper content", { +testthat::test_that("e2e - tm_outliers: Outlier table is displayed with proper content.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() diff --git a/tests/testthat/test-shinytest2-tm_variable_browser.R b/tests/testthat/test-shinytest2-tm_variable_browser.R index c270c9d8a..a81aa2acb 100644 --- a/tests/testthat/test-shinytest2-tm_variable_browser.R +++ b/tests/testthat/test-shinytest2-tm_variable_browser.R @@ -26,7 +26,7 @@ app_driver_tm_variable_browser <- function() { ) } -testthat::test_that("e2e - tm_variable_browser: Content is displayed correctly", { +testthat::test_that("e2e - tm_variable_browser: content is displayed correctly.", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -61,7 +61,7 @@ testthat::test_that("e2e - tm_variable_browser: Content is displayed correctly", app_driver$stop() }) -testthat::test_that("e2e - tm_variable_browser: Selecting 'treat variable as factor' changes the table headers", { +testthat::test_that("e2e - tm_variable_browser: Selecting 'treat variable as factor' changes the table headers.", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -93,8 +93,7 @@ testthat::test_that("e2e - tm_variable_browser: Selecting 'treat variable as fac app_driver$stop() }) - -testthat::test_that("e2e - tm_variable_browser: Selection of categorical variable has a table with 'level' header", { +testthat::test_that("e2e - tm_variable_browser: selection of categorical variable has a table with 'level' header.", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -148,8 +147,7 @@ testthat::test_that("e2e - tm_variable_browser: Selection of categorical variabl app_driver$stop() }) - -testthat::test_that("e2e - tm_variable_browser: Changing 'display density' encoding doesn't show errors", { +testthat::test_that("e2e - tm_variable_browser: changing 'display density' encoding doesn't show errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -164,7 +162,7 @@ testthat::test_that("e2e - tm_variable_browser: Changing 'display density' encod app_driver$stop() }) -testthat::test_that("e2e - tm_variable_browser: Changing 'outlier definition' encoding doesn't show errors", { +testthat::test_that("e2e - tm_variable_browser: changing 'outlier definition' encoding doesn't show errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() @@ -191,7 +189,7 @@ testthat::test_that("e2e - tm_variable_browser: Changing 'outlier definition' en app_driver$stop() }) -testthat::test_that("e2e - tm_variable_browser: Changing plot setting encodings doesn't show errors", { +testthat::test_that("e2e - tm_variable_browser: changing plot setting encodings doesn't show errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_variable_browser() From 35b0d36715df93dfa9041cf7933a642e0ca2eb8f Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 22 Apr 2024 20:38:49 +0530 Subject: [PATCH 3/6] adding missing call --- tests/testthat/test-shinytest2-tm_a_pca.R | 51 +++++++++++++---------- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/tests/testthat/test-shinytest2-tm_a_pca.R b/tests/testthat/test-shinytest2-tm_a_pca.R index c596f7151..9c5bd6b7a 100644 --- a/tests/testthat/test-shinytest2-tm_a_pca.R +++ b/tests/testthat/test-shinytest2-tm_a_pca.R @@ -33,9 +33,7 @@ app_driver_tm_a_pca <- function() { ) } -# Defaults -------------------------------------------------------------------- - -testthat::test_that("e2e - tm_a_pca: Module is initialised with the specified defaults in function call", { +testthat::test_that("e2e - tm_a_pca: Module is initialised with the specified defaults in function call.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -59,9 +57,7 @@ testthat::test_that("e2e - tm_a_pca: Module is initialised with the specified de app_driver$stop() }) -# Data extract ---------------------------------------------------------------- - -testthat::test_that("e2e - tm_a_pca: Eigenvector table should have data extract selection Murder/Assault on header", { +testthat::test_that("e2e - tm_a_pca: Eigenvector table should have data extract selection Murder/Assault on header.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -74,9 +70,11 @@ testthat::test_that("e2e - tm_a_pca: Eigenvector table should have data extract testthat::expect_match(app_driver$get_active_module_output("tbl_eigenvector"), "Murder") testthat::expect_no_match(app_driver$get_active_module_output("tbl_eigenvector"), "UrbanPop") + + app_driver$stop() }) -testthat::test_that("e2e - tm_a_pca: Eigenvector table should have data extract selection Murder/UrbanPop on header", { +testthat::test_that("e2e - tm_a_pca: Eigenvector table should have data extract selection Murder/UrbanPop on header.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -89,9 +87,11 @@ testthat::test_that("e2e - tm_a_pca: Eigenvector table should have data extract testthat::expect_match(app_driver$get_active_module_output("tbl_eigenvector"), "UrbanPop") testthat::expect_match(app_driver$get_active_module_output("tbl_eigenvector"), "Murder") testthat::expect_no_match(app_driver$get_active_module_output("tbl_eigenvector"), "Assault") + + app_driver$stop() }) -testthat::test_that("e2e - tm_a_pca: Color by columns (data_extract) must be from non-selected variable set", { +testthat::test_that("e2e - tm_a_pca: Color by columns (data_extract) must be from non-selected variable set.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -108,9 +108,7 @@ testthat::test_that("e2e - tm_a_pca: Color by columns (data_extract) must be fro app_driver$stop() }) -# Encodings ------------------------------------------------------------------- - -testthat::test_that("e2e - tm_a_pca: Changing output encodings of tables_display does not generate errors", { +testthat::test_that("e2e - tm_a_pca: Changing output encodings of tables_display does not generate errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -127,9 +125,11 @@ testthat::test_that("e2e - tm_a_pca: Changing output encodings of tables_display testthat::expect_type(app_driver$get_active_module_output("tbl_eigenvector"), "list") testthat::expect_setequal(names(app_driver$get_active_module_output("tbl_eigenvector")), c("message", "call", "type")) + + app_driver$stop() }) -testthat::test_that("e2e - tm_a_pca: Changing output encodings for 'plot type' does not generate errors", { +testthat::test_that("e2e - tm_a_pca: Changing output encodings for 'plot type' does not generate errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -148,9 +148,11 @@ testthat::test_that("e2e - tm_a_pca: Changing output encodings for 'plot type' d app_driver$set_active_module_input("plot_type", "Elbow plot") # Initial value app_driver$expect_no_validation_error() + + app_driver$stop() }) -testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'standardization' does not generate errors", { +testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'standardization' does not generate errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -159,14 +161,16 @@ testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'standardizati # Pre-processing app_driver$set_active_module_input("standardization", "center") - app_driver$expect_no_validation_error + app_driver$expect_no_validation_error() app_driver$set_active_module_input("standardization", "center_scale") - app_driver$expect_no_validation_error + app_driver$expect_no_validation_error() app_driver$set_active_module_input("standardization", "none") # Initial value - app_driver$expect_no_validation_error + app_driver$expect_no_validation_error() + + app_driver$stop() }) -testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'NA action' does not generate errors", { +testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'NA action' does not generate errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -176,9 +180,11 @@ testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'NA action' do app_driver$set_active_module_input("na_action", "drop") app_driver$set_active_module_input("na_action", "none") + + app_driver$stop() }) -testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'plot_type' hides and shows options", { +testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'plot_type' hides and shows options.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -206,9 +212,11 @@ testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'plot_type' hi testthat::expect_false(app_driver$is_visible(no_plot_settings_selector)) testthat::expect_true(app_driver$is_visible(x_axis_selector)) testthat::expect_true(app_driver$is_visible(color_by_selector)) + + app_driver$stop() }) -testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'theme' does not generate errors", { +testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'theme' does not generate errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() @@ -222,16 +230,17 @@ testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'theme' does n app_driver$expect_no_validation_error() app_driver$set_active_module_input("ggtheme-selectized", "dark") app_driver$expect_no_validation_error() + + app_driver$stop() }) -testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'font size' does not generate errors", { +testthat::test_that("e2e - tm_a_pca: Changing output encodings of 'font size' does not generate errors.", { skip_if_too_deep(5) app_driver <- app_driver_tm_a_pca() app_driver$expect_no_validation_error() # Font size - app_driver$set_active_module_input("font_size", "8") app_driver$expect_no_validation_error() From 65d4f2b7f3bd4e8a28da302363be8532a3a20fc3 Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 22 Apr 2024 21:19:24 +0530 Subject: [PATCH 4/6] fixing lintr --- tests/testthat/test-shinytest2-tm_outliers.R | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/testthat/test-shinytest2-tm_outliers.R b/tests/testthat/test-shinytest2-tm_outliers.R index fa9ad0acb..a846c2a8b 100644 --- a/tests/testthat/test-shinytest2-tm_outliers.R +++ b/tests/testthat/test-shinytest2-tm_outliers.R @@ -184,7 +184,8 @@ testthat::test_that("e2e - tm_outliers: Method parameters are set properly.", { app_driver$stop() }) -testthat::test_that("e2e - tm_outliers: Outlier definition text and range are displayed properly depending on method.", { +testthat::test_that("e2e - tm_outliers: + Outlier definition text and range are displayed properly depending on method.", { skip_if_too_deep(5) app_driver <- app_driver_tm_outlier() From 66b690410c0482b7aafe579612e522cc2a056622 Mon Sep 17 00:00:00 2001 From: kartikeyakirar Date: Tue, 23 Apr 2024 14:24:45 +0530 Subject: [PATCH 5/6] 'trigger' From ab9bff6633e1093219747764b8733d5d5ab6abb0 Mon Sep 17 00:00:00 2001 From: kartikeyakirar Date: Tue, 23 Apr 2024 16:31:45 +0530 Subject: [PATCH 6/6] 'trigger'