Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: do we need logger in teal.osprey? #275

Open
m7pr opened this issue Jun 19, 2024 · 1 comment
Open

[Question]: do we need logger in teal.osprey? #275

m7pr opened this issue Jun 19, 2024 · 1 comment
Labels
core question Further information is requested

Comments

@m7pr
Copy link
Contributor

m7pr commented Jun 19, 2024

The only usage of logger is in tests

logger::log_appender(function(...) NULL, namespace = "teal.osprey")

logger::log_appender(function(...) NULL, namespace = "teal.osprey")

and we have logger in Suggests becuase of that. Not a big deal, but I though teal.logger usage in R/zzz.R should cover and logger is not needed.

@m7pr
Copy link
Contributor Author

m7pr commented Jun 19, 2024

Looks like it just removes logs from being printed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant