Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter manager dialog doesn't handle too many modules #394

Open
chlebowa opened this issue Jul 20, 2023 · 4 comments
Open

filter manager dialog doesn't handle too many modules #394

chlebowa opened this issue Jul 20, 2023 · 4 comments
Labels
bug Something isn't working core

Comments

@chlebowa
Copy link
Contributor

image

@chlebowa chlebowa added bug Something isn't working core labels Jul 20, 2023
@chlebowa
Copy link
Contributor Author

Updating CSS with scroll: overflow helps but the aesthetics needs work.

image

@donyunardi
Copy link
Contributor

donyunardi commented Sep 14, 2023

Acceptance Criteria

  • The modules filter overview should fit within the modal (snapshot manager), pleasing to see and interact with.

@averissimo
Copy link
Contributor

averissimo commented Sep 15, 2023

To consider:

Using overflow-x: scroll and adding row-gap: 2em on the parent element with class filter_manager_content)

The row-gap only appears if flex overflows to 2 rows (so there's no additional padding in most scenarios)

image

@averissimo
Copy link
Contributor

There's an edge case when:

  • Scenario: There are many filters (let's say 20)
  • Result: The snapshot manager can be pushed below the window height (user would need to scroll the page down)

To avoid that we may hide filters when they are more than X (X = 5 in the mock below, but should be more)

The caveat is that this only makes sense in single "column mode", as in most dashboards both columns are visible.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

No branches or pull requests

3 participants