Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate bioconductor dependencies from teal.slice #500

Open
donyunardi opened this issue Dec 20, 2023 · 2 comments
Open

Separate bioconductor dependencies from teal.slice #500

donyunardi opened this issue Dec 20, 2023 · 2 comments
Labels

Comments

@donyunardi
Copy link
Contributor

donyunardi commented Dec 20, 2023

Summary

Prior discussion here

As part of preparing to release teal.slice to CRAN, we will create a new package that extends teal.slice to support MultiAssayExperiment and SummarizedExperiment dependencies.

The proposed package name is teal.slice.bio.

Tasks

For teal.slice.bio update

  • Create a repo in insightengineering for teal.slice.bio (IDR support will be needed here)
  • teal.slice.bio will be an extension of teal.slice with MultiAssayExperiment and SummarizedExperiment dependencies
    • teal.slice should be in Depends.
  • Update changes in teal.gallery pipeline for RNA-seq example app (i.e. code update, renv.lock file, etc).
  • Update this vignette in teal.
  • Setup development chores:
    • pkgdown
    • create pre-commit config file
    • .lintr
    • stage_dependencies.yaml
  • Setup verdepcheck
  • Do we need vignette for this package?
  • Add unit tests
  • Pass R CMD Check

Notes from @danielinteractive:

For teal.slice update

  • Remove MultiAssayExperiment and SummarizedExperiment dependencies from teal.slice.
  • Do we need to notify users when attempting to use MAE by prompting them to install and load teal.slice.bio?
  • Check documentation to ensure to mention of MAE or SE (i.e. roxygen, vignettes, etc).
  • Pass R CMD Check

For teal.modules.hermes update

  • Update package dependencies for modules (i.e. tm.hermes) to use teal.slice.bio. It should be in Depends.
  • Pass R CMD Check

For teal.modules.helios update

  • Update package dependencies for modules (i.e. tm.hermes) to use teal.slice.bio. It should be in Depends.
  • Pass R CMD Check

For teal.gallery update

  • Update changes in teal.gallery pipeline for affected example app (i.e. code update, renv.lock file, etc).
@donyunardi donyunardi changed the title Separate bioconductor dependency fromteal.slice Separate bioconductor dependencies fromteal.slice Dec 20, 2023
@donyunardi donyunardi changed the title Separate bioconductor dependencies fromteal.slice Separate bioconductor dependencies from teal.slice Dec 20, 2023
@donyunardi donyunardi mentioned this issue Dec 20, 2023
34 tasks
@donyunardi
Copy link
Contributor Author

cc'ing @danielinteractive @BFalquet for awareness

@lcd2yyz
Copy link

lcd2yyz commented Jan 2, 2024

Agree with the proposed concept, but suggest to name new pkg to teal.slice.bioc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants