Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One example on the decorator vingette doesn't work locally #1424

Closed
llrs-roche opened this issue Nov 22, 2024 · 3 comments
Closed

One example on the decorator vingette doesn't work locally #1424

llrs-roche opened this issue Nov 22, 2024 · 3 comments
Labels
bug Something isn't working core

Comments

@llrs-roche
Copy link
Contributor

The interactive-from lang example doesn't change the axis labels (on current branch status):

decorator_interactive_from_lang.mp4

The interactive_decorator_lang decorator uses make_teal_transform_server which is also used by static_decorator ( used in no-ui tab example) but on that example there is no possible change on the axis by the app user.

Other examples showing how to use decorators to change the axis interactively via function or with an interactive decorator work though.

My current understanding is that at 1187_decorate_output%40main/R/module_transform_data.R#L96 the teal_data has already the new x_axis_title (on third or fourth pass).

I think that make_teal_transform_server() seems to be run only once, instead of react to different input.

Originally posted by @llrs-roche in #1357 (comment)

@llrs-roche llrs-roche added bug Something isn't working core labels Nov 22, 2024
@m7pr
Copy link
Contributor

m7pr commented Nov 26, 2024

@llrs-roche would you be able to verify now, after this commit was provided in the feature branch?
6c353fe

@llrs-roche
Copy link
Contributor Author

Yes fixed now.

Grabacion.de.pantalla.2024-11-26.125654.mp4

@m7pr
Copy link
Contributor

m7pr commented Nov 26, 2024

🔥
great job @averissimo and thanks @llrs-roche for reporting and double checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

No branches or pull requests

2 participants