Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CadastralParcel.zoning expects BasicPropertyUnit instead of CadastralZoning #251

Open
JohannaOtt opened this issue May 3, 2019 · 12 comments
Assignees
Labels
solved Solution developed and accepted, not yet deployed

Comments

@JohannaOtt
Copy link

Hello,

When validating CadastralParcel data (http://inspire-sandbox.jrc.ec.europa.eu/etf-webapp/v2/TestRuns/EID5d3eaf52-95e6-4a08-ad8d-82a08aef6a25.html) the test with Assertion ID EID07480090-9995-4d98-bdfd-9bdeb0d2dc67 fails and shows the error message "CadastralParcel 'CadastralParcel_163835003003890050__', property 'zoning': The property references a resource at '#CadastralZoning_163835003', but the resource is not an 'BasicPropertyUnit' or one of its known subtypes. Found: element 'CadastralZoning' in namespace 'http://inspire.ec.europa.eu/schemas/cp/4.0'".
According to the UML diagram https://inspire.ec.europa.eu/data-model/approved/r4618-ir/html/index.htm?goto=2:1:3:1:7204 and line 414 of the XSD view-source:https://inspire.ec.europa.eu/schemas/cp/4.0/CadastralParcels.xsd the association 'zoning' should expect a resource of the type CadastralZoning. The validator currently expects one of BasicPropertyUnit according to

let $target := 'BasicPropertyUnit'

If needed, I could send the GML tested via email.

All the best

Johanna

@josemasensio
Copy link
Contributor

Dear @JohannaOtt,

Thank you for your comment. We need the GML to test it in the validator. You could attach the GML in ZIP format, just write a new comment and drag and drop the ZIP file into the text box.

Best regards.

@JohannaOtt
Copy link
Author

@bilbomaticaue Thank you for your reply. I would rather send it per email as it is proposed in the ticket creation template. Please let me know where I can send it to.

Best regards.

@josemasensio
Copy link
Contributor

@JohannaOtt you can send it to [email protected].

Thank you and regards.

@josemasensio
Copy link
Contributor

Dear @JohannaOtt,

We understand the problem that you are posing, looks like there is a bug in the validator. The possible solution is change the value 'BasicPropertyUnit' to 'CadastralZoning' in the test validation (like in the attached image).

screenshot

We are going to discuss the solution in the next subgroup meeting and see if the test should be modified.

Best regards.

@JohannaOtt
Copy link
Author

Thank you for the feedback!

@michellutz
Copy link

Indeed this is a clear bug to be corrected. No need to discuss it in the sub-group.

@inakidiazdecerio, please proceed with the fix. Thanls.

inakidiazdecerio added a commit that referenced this issue May 10, 2019
The value 'BasicPropertyUnit' is changed to 'CadastralZoning' in the test validation 'cp-ia.b.4: CadastralParcel.zoning'.
inakidiazdecerio added a commit that referenced this issue May 10, 2019
Modifications in the ETS to solve the bug detected in the issue #251
@josemasensio
Copy link
Contributor

Dear @JohannaOtt,

We are happy to announce that the solution for this issue has been implemented in the INSPIRE Validator. We have prepared a testing environment with the solution. The solution passed our quality controls, but we will appreciate if you could test it before deploying it in production.

You will find the solution deployed in following link:

http://sc01etfstaging.desarrollo.guadaltel.es/etf-webapp-bugfix/

Thanks in advance for your help.

@JohannaOtt
Copy link
Author

Thank you for the fix and the link. When trying to test it I am running into the following error message: "Error: La aplicación necesita autenticación
Por favor, conéctese usando su usuario de redmine e inténtelo de nuevo.
Si el error persiste contacte con el equipo de proyecto."

@MarcoMinghini
Copy link
Contributor

Dear @JohannaOtt,
the Validator instance to be used for testing is the following: http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp
Sorry for the confusion. Please give us some feedback after testing.

@JohannaOtt
Copy link
Author

Dear @bilbomaticaue @MarcoMinghini ,
I tested the behaviour with the instance mentioned and the dataset I used when running into the issue. It passes the test with ID EID07480090-9995-4d98-bdfd-9bdeb0d2dc67 as expected.
Thank you for your quick replies and fixing. Do you have a rough estimate when this fix will be available on the http://inspire-sandbox.jrc.ec.europa.eu/etf-webapp/ instance?

@MarcoMinghini
Copy link
Contributor

Dear @JohannaOtt,
we are in the process of deploying the INSPIRE Reference Validator on the cloud. The instance at http://inspire-sandbox.jrc.ec.europa.eu/etf-webapp/ will be dismissed soon (an announcement will be made) and the production instance will be also deployed on the cloud. The fix should be implemented in the production instance over the next months. Check the changelog and the release planning for news.
However, we introduced the staging instance exactly to have a version which is always up-to-date with the latest improvements (in terms of fixes and also new functionality). This staging instance anticipates what will be eventually deployed in the production instance.

@JohannaOtt
Copy link
Author

Dear @MarcoMinghini Thank you for the update!

inakidiazdecerio added a commit that referenced this issue May 14, 2019
The value 'BasicPropertyUnit' is changed to 'CadastralZoning' in the test validation 'cp-ia.b.4: CadastralParcel.zoning'.
@MarcoMinghini MarcoMinghini reopened this May 14, 2019
@MarcoMinghini MarcoMinghini added solved Solution developed and accepted, not yet deployed and removed ready for testing labels May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved Solution developed and accepted, not yet deployed
Projects
None yet
Development

No branches or pull requests

5 participants