Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected comment lines are very hard to read #2

Open
Stanzilla opened this issue Nov 4, 2017 · 5 comments
Open

Selected comment lines are very hard to read #2

Stanzilla opened this issue Nov 4, 2017 · 5 comments
Assignees

Comments

@Stanzilla
Copy link

See
code_2017-11-04_02-40-51

@instaatze instaatze self-assigned this Nov 8, 2017
@instaatze
Copy link
Owner

Thanks for the request!
Unfortunately, I'm not sure what I can do about that. The syntax highlighting (comment color) and the workbench/editor theming (selection color) are independently of each other, and there is no way to change the comment color only when selected.

@Stanzilla
Copy link
Author

@alexanderbast Which of those do you want me to subscribe to? https://github.com/Microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+theming 😄

@Stanzilla
Copy link
Author

@alexanderbast there have been a few additions to https://code.visualstudio.com/docs/getstarted/theme-color-reference recently, any chance you now have what it needs to fix this?

@instaatze
Copy link
Owner

Unfortunately not: microsoft/vscode#36490. I'm subscribed to this issue and will implement this as soon as possible.

@0x80
Copy link

0x80 commented Jul 25, 2020

@alexanderbast Could you maybe give an example on how to change the comment color? The instructions only tell me what settings properties to use, but not what colors (names?) are available and how to specify them (hex string?).

I love the Plus w/ Italics but the comments (even without selection) are really too dark for me. In my repository the comments are valuable and I want to be able to read them clearly.

--- edit ---

Never mind I think I can figure it out from looking at your JSON file. Still, I think it would be helpful to put some of it in the instructions.

--- edit ---

And now I realize Snazzy Plus comes from a different extension 😄 Anyway, if it is useful to anyone this is how you change the color of comments:

"editor.tokenColorCustomizations": {
    "[Snazzy]": {
      "comments": "#fff"
    }
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants