Skip to content

Commit

Permalink
better comment
Browse files Browse the repository at this point in the history
  • Loading branch information
clangenb committed Oct 26, 2024
1 parent 477ed7f commit 9c36e74
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions core/direct-rpc-server/src/rpc_responder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,12 @@ where

if do_watch {
// We just store back the initial response, which is the top hash.
// This was implemented before we added the `RpcSubscriptionUpdate`
// and should probably be refactored in the future, see #1624.
// This was implemented before we added the `RpcSubscriptionUpdate`,
// which can't be stored due to type incompatibilities.
// This should probably be refactored in the future, see #1624.
//
// But for now this is fine, as we only use it to track ongoing connections.
// But for now this is fine, as we only use the connection token
// to track ongoing connections, the response is ignored.
self.connection_registry.store(hash, connection_token, rpc_response);
}

Expand Down

0 comments on commit 9c36e74

Please sign in to comment.