Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint avoidance for width expansion #444

Open
mkorbel1 opened this issue Dec 11, 2023 · 2 comments · May be fixed by #478
Open

Improve lint avoidance for width expansion #444

mkorbel1 opened this issue Dec 11, 2023 · 2 comments · May be fixed by #478
Labels
enhancement New feature or request

Comments

@mkorbel1
Copy link
Contributor

Motivation

The current implementation (#298, #423) for handling width expansion (e.g. from adding, shift left, multiplication, etc.) avoids lint errors successfully, but still hits some lint warnings and is also somewhat ugly.

A nicer way to generate it might look something like this:

assign {cout, out} = a + b + cin;

Desired solution

Upgrade modules to generate prettier SV that avoids both lint errors and warnings

Alternatives considered

No response

Additional details

No response

@mkorbel1 mkorbel1 added the enhancement New feature or request label Dec 11, 2023
@mkorbel1
Copy link
Contributor Author

mkorbel1 commented Jan 8, 2024

We should investigate free/open-source linting tools for checking and CI flows to help catch issues and prevent regressions. Perhaps verilator's linting can help? https://projectf.io/posts/verilog-lint-with-verilator/

@mkorbel1
Copy link
Contributor Author

Another open-source linter: https://github.com/dalance/svlint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant