Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getGriefingCollateral tests #516

Closed
bvotteler opened this issue Dec 21, 2022 · 1 comment
Closed

Fix getGriefingCollateral tests #516

bvotteler opened this issue Dec 21, 2022 · 1 comment

Comments

@bvotteler
Copy link
Contributor

Adding multi-collateral vaults to the tests have broken “should getGriefingCollateral” tests for both issue and replace.

It seems the running oracle is interfering with the artificially set exchange rate.

To fix: Look at oracle tests where we use mocks to fix the exchange rate for the scope of the test and re-use that pattern.

Additional note: Look at Greg’s comment here, and check if these tests can be reworked completely

@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
@gregdhill
Copy link
Member

Closed by #578

@github-project-automation github-project-automation bot moved this from Todo ⏳ to Done ✅ in Backlog Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants