Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debug] Failing imports from utils/currency.ts in tests #607

Closed
peterslany opened this issue Mar 9, 2023 · 0 comments
Closed

[debug] Failing imports from utils/currency.ts in tests #607

peterslany opened this issue Mar 9, 2023 · 0 comments
Assignees
@peterslany
Labels
bug Something isn't working prio:medium

Comments

@peterslany
Copy link
Contributor

peterslany commented Mar 9, 2023 •
edited
Loading

Describe the bug
Importing newMonetaryAmount and tokenSymbolToCurrency in tests using relative import from src/ index file is not working - functions are undefined. To resolve the issue, these have to be imported from utils folder separately which creates unwanted inconsistency in imports.

Error message example:
TypeError: src_1.newMonetaryAmount is not a function

Additional context
This problem started occurring with #604 in which the monetary lib was updated to newer version. Both problematic functions are dependent on monetary.js
@peterslany peterslany added bug Something isn't working prio:medium labels Mar 9, 2023
@nud3l nud3l added this to Backlog Mar 9, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Mar 9, 2023
@peterslany peterslany changed the title [debug] Failing newMonetaryAmount imports in tests [debug] Failing imports from utils/currency.ts in tests Mar 10, 2023
@nud3l nud3l moved this from New 🆕 to Todo ⏳ in Backlog Mar 13, 2023
@peterslany peterslany self-assigned this Mar 14, 2023
@github-project-automation github-project-automation bot moved this from Todo ⏳ to Done ✅ in Backlog Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterslany peterslany

Labels
bug Something isn't working prio:medium
Projects
Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterslany