From b217ece486847c0f65be51dd4aa309b4c96d3aa3 Mon Sep 17 00:00:00 2001 From: nakul1010 Date: Tue, 15 Aug 2023 19:15:41 +0530 Subject: [PATCH] fix: test cases --- crates/redeem/src/lib.rs | 20 +- crates/redeem/src/tests.rs | 8 +- .../runtime/runtime-tests/src/parachain.rs | 1 + .../runtime-tests/src/parachain/replace.rs | 953 ++++++++++++++++++ 4 files changed, 974 insertions(+), 8 deletions(-) create mode 100644 parachain/runtime/runtime-tests/src/parachain/replace.rs diff --git a/crates/redeem/src/lib.rs b/crates/redeem/src/lib.rs index 93c24f9573..887212c2e5 100644 --- a/crates/redeem/src/lib.rs +++ b/crates/redeem/src/lib.rs @@ -172,6 +172,10 @@ pub mod pallet { AmountBelowDustAmount, /// Invalid Cancel request. InvalidCancelRequest, + /// Cannot replace self. + ReplaceSelfNotAllowed, + /// Vault cannot replace different currency. + InvalidWrappedCurrency, } /// The time difference in number of blocks between a redeem request is created and required completion time by a @@ -541,6 +545,16 @@ impl Pallet { let old_vault = AccountOrVault::Vault(old_vault_id.clone()); let new_vault = AccountOrVault::Vault(new_vault_id.clone()); + // probably this check is not strictly required, but it's better to give an + // explicit error rather than insufficient balance + ensure!( + old_vault_id.wrapped_currency() == new_vault_id.wrapped_currency(), + Error::::InvalidWrappedCurrency + ); + + // don't allow vaults to replace themselves + ensure!(old_vault != new_vault, Error::::ReplaceSelfNotAllowed); + // Calculate requestable tokens for old vault let max_requestable_tokens: Amount = ext::vault_registry::requestable_to_be_replaced_tokens::(&old_vault_id)?; @@ -589,12 +603,12 @@ impl Pallet { ensure!(!btc_address.is_zero(), btc_relay::Error::::InvalidBtcHash); // todo: currently allowed to redeem from one currency to the other for free - decide if this is desirable - let fee_wrapped = if redeemer.get_account().clone() == vault_id.account_id { + let mut fee_wrapped = if redeemer.get_account().clone() == vault_id.account_id { Amount::zero(vault_id.wrapped_currency()) } else { ext::fee::get_redeem_fee::(&amount_wrapped)? }; - let inclusion_fee = Self::get_current_inclusion_fee(vault_id.wrapped_currency())?; + let mut inclusion_fee = Self::get_current_inclusion_fee(vault_id.wrapped_currency())?; let vault_to_be_burned_tokens = amount_wrapped.checked_sub(&fee_wrapped)?; @@ -634,6 +648,8 @@ impl Pallet { }; let to_be_received_btc = if redeemer.is_vault_account() { + fee_wrapped = Amount::zero(vault_id.wrapped_currency()); + inclusion_fee = Amount::zero(vault_id.wrapped_currency()); amount_wrapped.amount() } else { user_to_be_received_btc.amount() diff --git a/crates/redeem/src/tests.rs b/crates/redeem/src/tests.rs index 45596376b8..5971da5588 100644 --- a/crates/redeem/src/tests.rs +++ b/crates/redeem/src/tests.rs @@ -803,9 +803,7 @@ mod redeem_replace_tests { premium: 0, vault_id: OLD_VAULT, btc_address, - transfer_fee: Redeem::get_current_inclusion_fee(DEFAULT_WRAPPED_CURRENCY) - .unwrap() - .amount() + transfer_fee: 0 }); }) } @@ -828,9 +826,7 @@ mod redeem_replace_tests { vault_id: OLD_VAULT, amount: 10, fee: 0, - transfer_fee: Redeem::get_current_inclusion_fee(DEFAULT_WRAPPED_CURRENCY) - .unwrap() - .amount(), + transfer_fee: 0, }); assert_err!( diff --git a/parachain/runtime/runtime-tests/src/parachain.rs b/parachain/runtime/runtime-tests/src/parachain.rs index bd810607a6..cff8f8b063 100644 --- a/parachain/runtime/runtime-tests/src/parachain.rs +++ b/parachain/runtime/runtime-tests/src/parachain.rs @@ -12,4 +12,5 @@ mod loans; mod multisig; mod nomination; mod redeem; +mod replace; mod vault_registry; diff --git a/parachain/runtime/runtime-tests/src/parachain/replace.rs b/parachain/runtime/runtime-tests/src/parachain/replace.rs new file mode 100644 index 0000000000..7a87eb5336 --- /dev/null +++ b/parachain/runtime/runtime-tests/src/parachain/replace.rs @@ -0,0 +1,953 @@ +use crate::{ + setup::{assert_eq, issue_utils::assert_issue_request_event, redeem_utils::assert_redeem_request_event, *}, + utils::loans_utils::activate_lending_and_mint, +}; +use currency::Amount; +use issue::DefaultIssueRequest; +use redeem::DefaultRedeemRequest; +use sp_core::H256; + +type IssueCall = issue::Call; + +pub type VaultRegistryError = vault_registry::Error; + +const USER: [u8; 32] = ALICE; +const OLD_VAULT: [u8; 32] = BOB; +const NEW_VAULT: [u8; 32] = CAROL; + +fn test_with(execute: impl Fn(VaultId, VaultId) -> R) { + let test_with = |old_vault_currency, new_vault_currency, wrapped_currency, extra_vault_currency| { + ExtBuilder::build().execute_with(|| { + for currency_id in iter_collateral_currencies().filter(|c| !c.is_lend_token()) { + assert_ok!(OraclePallet::_set_exchange_rate(currency_id, FixedU128::one())); + } + if wrapped_currency != DEFAULT_WRAPPED_CURRENCY { + assert_ok!(OraclePallet::_set_exchange_rate(wrapped_currency, FixedU128::one())); + } + activate_lending_and_mint(Token(DOT), LendToken(1)); + set_default_thresholds(); + UserData::force_to(USER, default_user_state()); + let old_vault_id = VaultId::new(account_of(OLD_VAULT), old_vault_currency, wrapped_currency); + let new_vault_id = VaultId::new(account_of(NEW_VAULT), new_vault_currency, wrapped_currency); + CoreVaultData::force_to(&old_vault_id, default_vault_state(&old_vault_id)); + CoreVaultData::force_to(&new_vault_id, default_vault_state(&new_vault_id)); + LiquidationVaultData::force_to(default_liquidation_vault_state(&old_vault_id.currencies)); + + if let Some(other_currency) = extra_vault_currency { + assert_ok!(OraclePallet::_set_exchange_rate(other_currency, FixedU128::one())); + // check that having other vault with the same account id does not influence tests + let other_old_vault_id = VaultId::new( + old_vault_id.account_id.clone(), + other_currency, + old_vault_id.wrapped_currency(), + ); + CoreVaultData::force_to(&other_old_vault_id, default_vault_state(&other_old_vault_id)); + let other_new_vault_id = VaultId::new( + new_vault_id.account_id.clone(), + other_currency, + new_vault_id.wrapped_currency(), + ); + CoreVaultData::force_to(&other_new_vault_id, default_vault_state(&other_new_vault_id)); + } + VaultRegistryPallet::collateral_integrity_check(); + + execute(old_vault_id, new_vault_id) + }) + }; + test_with(Token(DOT), Token(KSM), Token(KBTC), None); + test_with(Token(DOT), Token(DOT), Token(IBTC), None); + test_with(Token(DOT), Token(DOT), Token(IBTC), Some(Token(KSM))); + test_with(Token(DOT), Token(KSM), Token(IBTC), None); + test_with(Token(KSM), Token(DOT), Token(IBTC), None); + test_with(ForeignAsset(1), Token(DOT), Token(IBTC), None); + test_with(Token(KSM), ForeignAsset(1), Token(IBTC), None); + test_with(LendToken(1), ForeignAsset(1), Token(IBTC), None); + test_with(Token(KSM), LendToken(1), Token(IBTC), None); +} + +fn test_without_initialization(execute: impl Fn(CurrencyId) -> R) { + ExtBuilder::build().execute_with(|| execute(Token(DOT))); + ExtBuilder::build().execute_with(|| execute(Token(KSM))); +} + +// pub fn withdraw_replace(old_vault_id: &VaultId, amount: Amount) -> DispatchResultWithPostInfo { +// VaultRegistryPallet::collateral_integrity_check(); +// +// RuntimeCall::Replace(ReplaceCall::withdraw_replace { +// currency_pair: old_vault_id.currencies.clone(), +// amount: amount.amount(), +// }) +// .dispatch(origin_of(old_vault_id.account_id.clone())) +// } + +// pub fn assert_replace_request_event() { +// let events = SystemPallet::events(); +// let ids = events.iter().filter_map(|r| match r.event { +// RuntimeEvent::Replace(ReplaceEvent::RequestReplace { .. }) => Some(()), +// _ => None, +// }); +// assert_eq!(ids.count(), 1); +// } + +#[cfg(test)] +mod request_replace_tests { + use super::{assert_eq, *}; + use crate::{setup::issue_utils::assert_issue_request_event, utils::redeem_utils::assert_redeem_request_event}; + + fn assert_state_after_accept_replace_correct( + old_vault_id: &VaultId, + new_vault_id: &VaultId, + issue: &IssueRequest, + amount: Amount, + ) { + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + ParachainTwoVaultState::get_default(&old_vault_id, &new_vault_id).with_changes( + |old_vault, new_vault, _| { + *old_vault.free_balance.get_mut(&issue.griefing_currency).unwrap() -= + Amount::new(issue.griefing_collateral, issue.griefing_currency); + + old_vault.to_be_redeemed += amount; + new_vault.to_be_issued += amount; + } + ) + ); + } + + #[test] + fn integration_test_replace_accept_replace_at_capacity_succeeds() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(DEFAULT_VAULT_TO_BE_REPLACED.amount()); + assert_ok!(RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: accept_amount.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone()))); + + let redeem_id = assert_redeem_request_event(); + let redeem = RedeemPallet::get_open_redeem_request_from_id(&redeem_id).unwrap(); + + assert_eq!(redeem.amount_btc, accept_amount.amount()); + assert_eq!(redeem.issue_id.is_some(), true); + + let issue_id = assert_issue_request_event(); + let issue = IssuePallet::get_issue_request_from_id(&issue_id).unwrap(); + + assert_eq!(issue.griefing_collateral(), griefing(2)); + assert_state_after_accept_replace_correct(&old_vault_id, &new_vault_id, &issue, accept_amount); + }); + } + + #[test] + fn integration_test_replace_accept_replace_below_capacity_succeeds() { + test_with(|old_vault_id, new_vault_id| { + // accept only 25% + + let accept_amount = DEFAULT_VAULT_TO_BE_REPLACED / 4; + let accept_amount = old_vault_id.wrapped(accept_amount.amount()); + + assert_ok!(RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: accept_amount.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone()))); + + let redeem_id = assert_redeem_request_event(); + let redeem = RedeemPallet::get_open_redeem_request_from_id(&redeem_id).unwrap(); + + assert_eq!(redeem.amount_btc, accept_amount.amount()); + assert_eq!(redeem.issue_id.is_some(), true); + + let issue_id = assert_issue_request_event(); + let issue = IssuePallet::get_issue_request_from_id(&issue_id).unwrap(); + + assert_eq!(issue.griefing_collateral(), griefing(1)); + assert_state_after_accept_replace_correct(&old_vault_id, &new_vault_id, &issue, accept_amount); + }); + } + + #[test] + fn integration_test_replace_accept_replace_above_capacity_succeeds() { + test_with(|old_vault_id, new_vault_id| { + // try to accept 400% + + let accept_amount = DEFAULT_VAULT_TO_BE_REPLACED * 4; + let accept_amount = old_vault_id.wrapped(accept_amount.amount()); + + assert_ok!(RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: accept_amount.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone()))); + + let redeem_id = assert_redeem_request_event(); + let redeem = RedeemPallet::get_open_redeem_request_from_id(&redeem_id).unwrap(); + + assert_eq!(redeem.amount_btc, accept_amount.amount() / 2); + assert_eq!(redeem.issue_id.is_some(), true); + + let issue_id = assert_issue_request_event(); + let issue = IssuePallet::get_issue_request_from_id(&issue_id).unwrap(); + + assert_eq!(issue.griefing_collateral(), griefing(4)); + assert_state_after_accept_replace_correct( + &old_vault_id, + &new_vault_id, + &issue, + Amount::new(accept_amount.amount() / 2, old_vault_id.currencies.wrapped), + ); + }); + } + + #[test] + fn integration_test_replace_accept_replace_by_vault_that_does_not_accept_issues_succeeds() { + test_with(|old_vault_id, new_vault_id| { + assert_ok!(RuntimeCall::VaultRegistry(VaultRegistryCall::accept_new_issues { + currency_pair: new_vault_id.currencies.clone(), + accept_new_issues: false + }) + .dispatch(origin_of(new_vault_id.account_id.clone()))); + + assert_noop!( + RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: 1000, + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone())), + IssueError::VaultNotAcceptingNewIssues + ); + }); + } + + #[test] + fn integration_test_replace_accept_replace_below_dust_fails() { + test_with(|old_vault_id, new_vault_id| { + // if the new_vault _asks_ for an amount below below DUST, it gets rejected + + assert_noop!( + RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: 1, + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone())), + IssueError::AmountBelowDustAmount + ); + }); + } + + #[test] + fn integration_test_replace_accept_replace_self_fails() { + test_with(|old_vault_id, _new_vault_id| { + assert_noop!( + RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: 10_000, + new_vault_id: old_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone())), + RedeemError::ReplaceSelfNotAllowed + ); + }); + } + + #[test] + fn integration_test_replace_other_wrapped_currency_fails() { + test_with(|old_vault_id, new_vault_id| { + let other_currency = if let Token(IBTC) = old_vault_id.wrapped_currency() { + Token(KBTC) + } else { + Token(IBTC) + }; + assert_ok!(OraclePallet::_set_exchange_rate(other_currency, FixedU128::one())); + + let new_vault_id = VaultId::new( + account_of(NEW_VAULT), + new_vault_id.collateral_currency(), + other_currency, + ); + CoreVaultData::force_to(&new_vault_id, default_vault_state(&new_vault_id)); + + //Fixme: The code works without this check, ideally shouldn't have worked? + assert_noop!( + RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: 10000, + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone())), + RedeemError::InvalidWrappedCurrency + ); + }) + } +} + +mod expiry_test { + use super::{assert_eq, *}; + use crate::{setup::redeem_utils::assert_redeem_request_event, utils::issue_utils::assert_issue_request_event}; + + /// test replace created by accept + fn test_with(initial_period: u32, execute: impl Fn((H256, H256))) { + let amount_btc = wrapped(5_000); + super::test_with(|old_vault_id, new_vault_id| { + set_replace_period(initial_period); + assert_ok!(RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: amount_btc.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone()))); + let redeem_id = assert_redeem_request_event(); + let issue_id = assert_issue_request_event(); + + execute((redeem_id, issue_id)); + }); + } + + fn set_replace_period(period: u32) { + assert_ok!(RuntimeCall::Redeem(RedeemCall::set_redeem_period { period }).dispatch(root())); + } + + fn cancel_replace(redeem_id: H256) -> DispatchResultWithPostInfo { + RuntimeCall::Redeem(RedeemCall::cancel_redeem { + redeem_id: redeem_id, + reimburse: true, + }) + .dispatch(origin_of(account_of(NEW_VAULT))) + } + + #[test] + fn integration_test_replace_expiry_only_parachain_blocks_expired() { + test_with(1000, |(redeem_id, _issue_id)| { + mine_blocks(1); + SecurityPallet::set_active_block_number(1500); + + assert_noop!(cancel_replace(redeem_id), RedeemError::TimeNotExpired); + assert_ok!(execute_replace(redeem_id)); + }); + } + + #[test] + fn integration_test_replace_expiry_only_bitcoin_blocks_expired() { + test_with(1000, |(redeem_id, _issue_id)| { + mine_blocks(15); + SecurityPallet::set_active_block_number(500); + + assert_noop!(cancel_replace(redeem_id), RedeemError::TimeNotExpired); + assert_ok!(execute_replace(redeem_id)); + }); + } + + #[test] + fn integration_test_replace_expiry_no_period_change_pre_expiry() { + test_with(1000, |(redeem_id, _issue_id)| { + mine_blocks(7); + SecurityPallet::set_active_block_number(750); + + assert_noop!(cancel_replace(redeem_id), RedeemError::TimeNotExpired); + assert_ok!(execute_replace(redeem_id)); + }); + } + + #[test] + fn integration_test_replace_expiry_no_period_change_post_expiry() { + // can still execute after expiry + test_with(1000, |(redeem_id, _issue_id)| { + mine_blocks(100); + SecurityPallet::set_active_block_number(1100); + + assert_ok!(execute_replace(redeem_id)); + }); + + // but new-vault can also cancel.. whoever is first wins + test_with(1000, |(redeem_id, _issue_id)| { + mine_blocks(100); + SecurityPallet::set_active_block_number(1100); + + assert_ok!(cancel_replace(redeem_id)); + }); + } + + #[test] + fn integration_test_replace_expiry_with_period_decrease() { + test_with(2000, |(redeem_id, _issue_id)| { + mine_blocks(15); + SecurityPallet::set_active_block_number(1100); + set_replace_period(1000); + + // request still uses period = 200, so cancel fails and execute succeeds + assert_err!(cancel_replace(redeem_id), RedeemError::TimeNotExpired); + assert_ok!(execute_replace(redeem_id)); + }); + } + + #[test] + fn integration_test_replace_expiry_with_period_increase() { + test_with(1000, |(redeem_id, _issue_id)| { + mine_blocks(15); + SecurityPallet::set_active_block_number(1100); + set_replace_period(2000); + + // request uses period = 200, so execute succeeds and cancel fails + assert_err!(cancel_replace(redeem_id), RedeemError::TimeNotExpired); + assert_ok!(execute_replace(redeem_id)); + }); + } +} + +mod execute_replace_payment_limits { + use super::{assert_eq, *}; + use crate::utils::redeem_utils::assert_redeem_request_event; + + #[test] + fn integration_test_execute_replace_with_exact_amount_succeeds() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = old_vault_id.wrapped(1000000); + + assert_ok!(RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: accept_amount.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone()))); + let redeem_id = assert_redeem_request_event(); + + let replace = RedeemPallet::get_open_redeem_request_from_id(&redeem_id).unwrap(); + + assert_ok!(execute_replace_with_amount( + redeem_id, + Amount::new(replace.amount_btc, replace.vault.currencies.wrapped) + )); + }); + } + + #[test] + fn integration_test_execute_replace_with_overpayment_fails() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = old_vault_id.wrapped(1000000); + + assert_ok!(RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: accept_amount.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone()))); + + let redeem_id = assert_redeem_request_event(); + + let replace = RedeemPallet::get_open_redeem_request_from_id(&redeem_id).unwrap(); + + assert_err!( + execute_replace_with_amount( + redeem_id, + Amount::new(replace.amount_btc, replace.vault.currencies.wrapped).with_amount(|x| x + 1) + ), + BTCRelayError::InvalidPaymentAmount + ); + }); + } + #[test] + fn integration_test_execute_replace_with_underpayment_fails() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = old_vault_id.wrapped(1000000); + + assert_ok!(RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: accept_amount.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone()))); + + let redeem_id = assert_redeem_request_event(); + + let replace = RedeemPallet::get_open_redeem_request_from_id(&redeem_id).unwrap(); + + assert_err!( + execute_replace_with_amount( + redeem_id, + Amount::new(replace.amount_btc, replace.vault.currencies.wrapped).with_amount(|x| x - 1) + ), + BTCRelayError::InvalidPaymentAmount + ); + }); + } +} + +fn setup_replace( + accept_amount: Amount, + old_vault_id: &VaultId, + new_vault_id: &VaultId, +) -> (H256, DefaultRedeemRequest, H256, DefaultIssueRequest) { + assert_ok!(RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: accept_amount.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone()))); + let redeem_id = assert_redeem_request_event(); + let redeem = RedeemPallet::get_open_redeem_request_from_id(&redeem_id).unwrap(); + + let issue_id = assert_issue_request_event(); + let issue = IssuePallet::get_issue_request_from_id(&issue_id).unwrap(); + + (redeem_id, redeem, issue_id, issue) +} + +#[test] +fn integration_test_replace_cancel_replace() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, _, _, _) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + // set block height + // new_vault cancels replacement + mine_blocks(2); + SecurityPallet::set_active_block_number(30); + assert_ok!(RuntimeCall::Redeem(RedeemCall::cancel_redeem { + redeem_id: redeem_id, + reimburse: true, + }) + .dispatch(origin_of(new_vault_id.account_id.clone()))); + }); +} + +// liquidation tests + +fn execute_replace(redeem_id: H256) -> DispatchResultWithPostInfo { + let replace = RedeemPallet::get_open_redeem_request_from_id(&redeem_id)?; + execute_replace_with_amount( + redeem_id, + Amount::new(replace.amount_btc, replace.vault.currencies.wrapped), + ) +} + +fn execute_replace_with_amount(redeem_id: H256, amount: Amount) -> DispatchResultWithPostInfo { + let replace = RedeemPallet::get_open_redeem_request_from_id(&redeem_id).unwrap(); + + // send the btc from the old_vault to the new_vault + let (_tx_id, _tx_block_height, transaction) = generate_transaction_and_mine( + Default::default(), + vec![], + vec![(replace.btc_address, amount)], + vec![redeem_id], + ); + + SecurityPallet::set_active_block_number(SecurityPallet::active_block_number() + CONFIRMATIONS); + + RuntimeCall::Redeem(RedeemCall::execute_redeem { + redeem_id, + unchecked_transaction: transaction, + }) + .dispatch(origin_of(account_of(OLD_VAULT))) +} + +fn cancel_replace(redeem_id: H256) { + // set block height + mine_blocks(2); + SecurityPallet::set_active_block_number(30); + assert_ok!(RuntimeCall::Redeem(RedeemCall::cancel_redeem { + redeem_id: redeem_id, + reimburse: true, + }) + .dispatch(origin_of(account_of(NEW_VAULT)))); +} + +#[test] +fn integration_test_replace_execute_replace_success() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + + let (redeem_id, _redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + let pre_execute_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + + assert_ok!(execute_replace(redeem_id)); + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_execute_state.with_changes(|old_vault, new_vault, _| { + old_vault.issued -= accept_amount; + old_vault.to_be_redeemed -= accept_amount; + *old_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + + new_vault.issued += accept_amount; + new_vault.to_be_issued -= accept_amount; + }) + ); + }); +} + +fn calculate_replace_collateral( + vault_data: &CoreVaultData, + replace_amount: Amount, + currency_id: CurrencyId, +) -> Amount { + Amount::new( + (vault_data.backing_collateral.amount() * replace_amount.amount()) + / (vault_data.issued + vault_data.to_be_issued).amount(), + currency_id, + ) +} + +#[test] +fn integration_test_replace_execute_replace_old_vault_liquidated() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + + let (redeem_id, redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + let old = CoreVaultData::vault(old_vault_id.clone()); + + liquidate_vault(&old_vault_id); + + let pre_execution_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + + assert_ok!(execute_replace(redeem_id)); + + let collateral_for_replace = + calculate_replace_collateral(&old, redeem.amount_btc(), old_vault_id.collateral_currency()); + + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_execution_state.with_changes(|old_vault, new_vault, liquidation_vault| { + let liquidation_vault = liquidation_vault.with_currency(&old_vault_id.currencies); + + liquidation_vault.issued -= accept_amount; + liquidation_vault.to_be_redeemed -= accept_amount; + + new_vault.to_be_issued -= accept_amount; + new_vault.issued += accept_amount; + + old_vault.to_be_redeemed -= accept_amount; + old_vault.liquidated_collateral -= collateral_for_replace; + *old_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + *old_vault + .free_balance + .get_mut(&old_vault_id.collateral_currency()) + .unwrap() += collateral_for_replace; + }) + ); + }); +} + +#[test] +fn integration_test_replace_execute_replace_new_vault_liquidated() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + + let (redeem_id, _redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + liquidate_vault(&new_vault_id); + + let pre_execution_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + + assert_ok!(execute_replace(redeem_id)); + + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_execution_state.with_changes(|old_vault, _new_vault, liquidation_vault| { + let liquidation_vault = liquidation_vault.with_currency(&new_vault_id.currencies); + + liquidation_vault.issued += accept_amount; + liquidation_vault.to_be_issued -= accept_amount; + + old_vault.to_be_redeemed -= accept_amount; + old_vault.issued -= accept_amount; + *old_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + }) + ); + }); +} + +#[test] +fn integration_test_replace_execute_replace_both_vaults_liquidated() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + + let (redeem_id, redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + let old = CoreVaultData::vault(old_vault_id.clone()); + + liquidate_vault(&old_vault_id); + liquidate_vault(&new_vault_id); + + let pre_execution_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + + assert_ok!(execute_replace(redeem_id)); + + let collateral_for_replace = + calculate_replace_collateral(&old, redeem.amount_btc(), old_vault_id.collateral_currency()); + + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_execution_state.with_changes(|old_vault, _new_vault, liquidation_vault| { + let old_liquidation_vault = liquidation_vault.with_currency(&old_vault_id.currencies); + old_liquidation_vault.to_be_redeemed -= accept_amount; + old_liquidation_vault.issued -= accept_amount; + + let new_liquidation_vault = liquidation_vault.with_currency(&new_vault_id.currencies); + new_liquidation_vault.to_be_issued -= accept_amount; + new_liquidation_vault.issued += accept_amount; + + old_vault.to_be_redeemed -= accept_amount; + old_vault.liquidated_collateral -= collateral_for_replace; + *old_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + *old_vault + .free_balance + .get_mut(&old_vault_id.collateral_currency()) + .unwrap() += collateral_for_replace; + }) + ); + }); +} + +#[test] +fn integration_test_replace_execute_replace_with_cancelled() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, _redeem, _issue_id, _issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + cancel_replace(redeem_id); + assert_err!(execute_replace(redeem_id), RedeemError::RedeemCancelled); + }); +} + +#[test] +fn integration_test_replace_cancel_replace_success() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, _redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + let pre_cancellation_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + cancel_replace(redeem_id); + + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_cancellation_state.with_changes(|old_vault, new_vault, _| { + new_vault.to_be_issued -= accept_amount; + *new_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + + old_vault.to_be_redeemed -= accept_amount; + }) + ); + }); +} + +#[test] +fn integration_test_replace_cancel_replace_old_vault_liquidated() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + let old = CoreVaultData::vault(old_vault_id.clone()); + + liquidate_vault(&old_vault_id); + + let pre_cancellation_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + + cancel_replace(redeem_id); + + let collateral_for_replace = + calculate_replace_collateral(&old, redeem.amount_btc(), old_vault_id.collateral_currency()); + + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_cancellation_state.with_changes(|old_vault, new_vault, liquidation_vault| { + let liquidation_vault = liquidation_vault.with_currency(&old_vault_id.currencies); + + old_vault.to_be_redeemed -= accept_amount; + old_vault.liquidated_collateral -= collateral_for_replace; + + new_vault.to_be_issued -= accept_amount; + *new_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + + liquidation_vault.to_be_redeemed -= accept_amount; + liquidation_vault.collateral += collateral_for_replace; + }) + ); + }); +} + +#[test] +fn integration_test_replace_cancel_replace_new_vault_liquidated() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, _redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + liquidate_vault(&new_vault_id); + + let pre_cancellation_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + + cancel_replace(redeem_id); + + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_cancellation_state.with_changes(|old_vault, new_vault, liquidation_vault| { + old_vault.to_be_redeemed -= accept_amount; + + *new_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + + let new_liquidation_vault = liquidation_vault.with_currency(&new_vault_id.currencies); + new_liquidation_vault.to_be_issued -= accept_amount; + }) + ); + }); +} + +#[test] +fn integration_test_replace_cancel_replace_both_vaults_liquidated() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + let old = CoreVaultData::vault(old_vault_id.clone()); + + liquidate_vault(&old_vault_id); + liquidate_vault(&new_vault_id); + + let pre_cancellation_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + + cancel_replace(redeem_id); + + let collateral_for_replace = + calculate_replace_collateral(&old, redeem.amount_btc(), old_vault_id.collateral_currency()); + + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_cancellation_state.with_changes(|old_vault, new_vault, liquidation_vault| { + old_vault.to_be_redeemed -= accept_amount; + old_vault.liquidated_collateral -= collateral_for_replace; + + *new_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + + let old_liquidation_vault = liquidation_vault.with_currency(&old_vault_id.currencies); + old_liquidation_vault.to_be_redeemed -= accept_amount; + old_liquidation_vault.collateral += collateral_for_replace; + + let new_liquidation_vault = liquidation_vault.with_currency(&new_vault_id.currencies); + new_liquidation_vault.to_be_issued -= accept_amount; + }) + ); + }); +} + +#[test] +fn integration_test_replace_vault_with_different_currency_succeeds() { + test_without_initialization(|currency_id| { + for currency_id in iter_collateral_currencies().filter(|c| !c.is_lend_token()) { + assert_ok!(OraclePallet::_set_exchange_rate(currency_id, FixedU128::one())); + } + set_default_thresholds(); + SecurityPallet::set_active_block_number(1); + + let other_currency = if let Token(DOT) = currency_id { + Token(KSM) + } else { + Token(DOT) + }; + + let old_vault_id = vault_id_of(OLD_VAULT, currency_id); + let new_vault_id = vault_id_of(NEW_VAULT, other_currency); + + // Mint lendTokens so that force-setting vault state doesn't fail + activate_lending_and_mint(Token(DOT), LendToken(1)); + CoreVaultData::force_to(&old_vault_id, default_vault_state(&old_vault_id)); + CoreVaultData::force_to(&new_vault_id, default_vault_state(&new_vault_id)); + + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, _redeem, _issue_id, issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + let pre_execute_state = ParachainTwoVaultState::get(&old_vault_id, &new_vault_id); + + assert_ok!(execute_replace(redeem_id)); + + assert_eq!( + ParachainTwoVaultState::get(&old_vault_id, &new_vault_id), + pre_execute_state.with_changes(|old_vault, new_vault, _| { + new_vault.to_be_issued -= accept_amount; + new_vault.issued += accept_amount; + old_vault.to_be_redeemed -= accept_amount; + old_vault.issued -= accept_amount; + + *old_vault.free_balance.get_mut(&DEFAULT_GRIEFING_CURRENCY).unwrap() += issue.griefing_collateral(); + }) + ); + }); +} + +mod oracle_down { + use super::{assert_eq, *}; + + #[test] + fn no_oracle_execute_replace_succeeds() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, _redeem, _issue_id, _issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + OraclePallet::expire_all(); + + assert_ok!(execute_replace(redeem_id)); + }); + } + + #[test] + fn no_oracle_request_replace_fails() { + test_with(|old_vault_id, new_vault_id| { + let amount = DEFAULT_VAULT_ISSUED - DEFAULT_VAULT_TO_BE_REDEEMED - DEFAULT_VAULT_TO_BE_REPLACED; + OraclePallet::expire_all(); + + assert_noop!( + RuntimeCall::Redeem(RedeemCall::request_replace { + currency_pair: old_vault_id.currencies.clone(), + amount: amount.amount(), + new_vault_id: new_vault_id.clone(), + griefing_currency: DEFAULT_GRIEFING_CURRENCY + }) + .dispatch(origin_of(old_vault_id.account_id.clone())), + OracleError::MissingExchangeRate + ); + }) + } + + #[test] + fn no_oracle_cancel_replace_succeeds() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, _redeem, _issue_id, _issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + OraclePallet::expire_all(); + + mine_blocks(2); + SecurityPallet::set_active_block_number(30); + + assert_ok!(RuntimeCall::Redeem(RedeemCall::cancel_redeem { + redeem_id: redeem_id, + reimburse: true, + }) + .dispatch(origin_of(account_of(NEW_VAULT)))); + }) + } + + #[test] + fn no_oracle_execute_cancelled_replace_succeeds() { + test_with(|old_vault_id, new_vault_id| { + let accept_amount = new_vault_id.wrapped(10000); + let (redeem_id, _redeem, _issue_id, _issue) = setup_replace(accept_amount, &old_vault_id, &new_vault_id); + + OraclePallet::expire_all(); + assert_ok!(execute_replace(redeem_id)); + }) + } +}