Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-Tenant] Fix tests & github actions on feature branch #2972

Closed
Tracked by #2893
njlie opened this issue Sep 11, 2024 · 2 comments
Closed
Tracked by #2893

[Multi-Tenant] Fix tests & github actions on feature branch #2972

njlie opened this issue Sep 11, 2024 · 2 comments
Assignees
Labels
type: tests Testing related

Comments

@njlie
Copy link
Contributor

njlie commented Sep 11, 2024

A lot of tests were broken by the fact that several existing tables have added foreign key constraints on tenantId. Now that the time constraint for Rafiki work week show and tell is no longer a factor, the feature branch should be brought up to the same standard as the main branch. In other words, new features should not break any existing tests or Github actions, and any tests & actions broken by features that are already merged in should be fixed.

@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Sep 11, 2024
@njlie njlie self-assigned this Sep 11, 2024
@njlie njlie moved this from Backlog to In Progress in Rafiki Sep 24, 2024
@njlie njlie added type: tests Testing related story Major feature that can be broken up into smaller tasks and removed story Major feature that can be broken up into smaller tasks labels Oct 11, 2024
@njlie
Copy link
Contributor Author

njlie commented Nov 15, 2024

Closing as current multi-tenancy feature branch implements deprecated design.

@njlie njlie closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Rafiki Nov 15, 2024
@njlie njlie reopened this Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Done to Backlog in Rafiki Nov 19, 2024
@njlie
Copy link
Contributor Author

njlie commented Nov 20, 2024

Closing again as we are using the original design for multi-tenancy, but are starting fresh.

@njlie njlie closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Rafiki Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tests Testing related
Projects
Status: Done
Development

No branches or pull requests

1 participant