Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configurable cookie SameSite header #2998

Closed
1 of 2 tasks
mkurapov opened this issue Sep 23, 2024 · 0 comments · Fixed by #3001
Closed
1 of 2 tasks

Allow configurable cookie SameSite header #2998

mkurapov opened this issue Sep 23, 2024 · 0 comments · Fixed by #3001
Assignees
@lengyel-arpad85
Labels
pkg: auth Changes in the GNAP auth package.

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Sep 23, 2024 •
edited by lengyel-arpad85
Loading

Context

We should allow a new ENV flag (INTERACTION_COOKIE_SAME_SITE) that is unset by default and allows the ASE to set it to lax, strict, or none if they want.

Todo

  • create optional INTERACTION_COOKIE_SAME_SITE env variable in auth
  • Verify that Lax Strict and None all work for our interaction flow
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Sep 23, 2024
@lengyel-arpad85 lengyel-arpad85 self-assigned this Sep 23, 2024
@mkurapov mkurapov added the pkg: auth Changes in the GNAP auth package. label Sep 23, 2024
@lengyel-arpad85 lengyel-arpad85 changed the title Allow configurable cooke SameSite header Allow configurable cookie SameSite header Sep 24, 2024
@lengyel-arpad85 lengyel-arpad85 linked a pull request Sep 24, 2024 that will close this issue
feat: Allow configurable cookie SameSite header #3001
Merged
@lengyel-arpad85 lengyel-arpad85 moved this from Backlog to In Progress in Rafiki Sep 24, 2024
@lengyel-arpad85 lengyel-arpad85 moved this from In Progress to Ready for Review in Rafiki Sep 24, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Rafiki Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lengyel-arpad85 lengyel-arpad85

Labels
pkg: auth Changes in the GNAP auth package.
Projects
Rafiki
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow configurable cookie SameSite header interledger/rafiki
2 participants
@mkurapov @lengyel-arpad85