feat(backend): tenant support for wallet address (#3114) #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nanted-wallet-addresses
github-actions
bot
added
type: tests
4 tasks
koekiebox
changed the title
koekiebox
changed the base branch from
2893/multi-tenancy-v1
to
nl/3123/backend-tenant-service
koekiebox
commented
Dec 9, 2024
| @@ -1213,6 +1226,8 @@ type CreateReceiverResponse { | |||
| } | |||
|
|
|||
| input CreateWalletAddressInput { | |||
| "Unique identifier of the tenant associated with the wallet address. This cannot be changed." | |||
| tenantId: String! | |||
There was a problem hiding this comment.
This would need to be removed at a later stage (once we obtain the tenant from the signature):
#2928
Base automatically changed from
nl/3123/backend-tenant-service
to
2893/multi-tenancy-v1
December 9, 2024 17:32
4 tasks
mkurapov
reviewed
Dec 9, 2024
| @@ -53,6 +62,9 @@ export class WalletAddress | |||
| public readonly assetId!: string | |||
| public asset!: Asset | |||
|
|
|||
| public readonly tenantId!: string | |||
| public tenant!: Tenant | |||
There was a problem hiding this comment.
Do we actually need the tenant!: Tenant property on the model? I'm not sure we'd end up using it
There was a problem hiding this comment.
Originally I thought we would need it, but since we have authServer and resourceServer, we are good. Will update.
| @@ -176,13 +181,19 @@ async function createWalletAddress( | |||
| const walletAddress = await WalletAddress.query( | |||
| deps.knex | |||
| ).insertGraphAndFetch({ | |||
| tenantId: options.tenantId, | |||
There was a problem hiding this comment.
I think we would need the gets and update to also take in tenantId in the query, right?
There was a problem hiding this comment.
I don't think so, since you cannot move a wallet between tenants? Unless that is something we want? @mkurapov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Checklist
fixes #numberuser-docslabel (if necessary)