Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "primary" selection from author merge tool #10124

Open
RayBB opened this issue Dec 6, 2024 · 9 comments
Open

Remove "primary" selection from author merge tool #10124

RayBB opened this issue Dec 6, 2024 · 9 comments
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @seabelis Issuses overseen by Lisa (Staff: Lead Community Librarian) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Dec 6, 2024

Proposal

Based on a discussion on Slack back in July.

We do not need to have a "primary" selection in the author merge tool.

As I understand it, @seabelis says we should always have the oldest OLID as the "primary".

As such, we can dramatically simplify the GUI the author merge (and later work merge) by removing the "primary" ratio button from the GUI.

On the backend, there will still be a primary but it should automatically be selected based on which is the oldest ID.

Current design of the author merge page
CleanShot 2024-12-06 at 01 06 04@2x

I imagine the end result should look something like this:
CleanShot 2024-12-06 at 01 12 00@2x

Perhaps we link to the docs for merging :)

Justification

The main reason I want this change is to simplify the experience for librarians and keep our UIs nice.

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead Affects: Librarians Issues related to features that librarians particularly need. [managed] labels Dec 6, 2024
@RayBB RayBB moved this to I'd like to work on it in Ray's Project Dec 6, 2024
@zorae
Copy link

zorae commented Dec 6, 2024

Make sure to handle cases in which the librarian deselects what would otherwise be the primary record

@mheiman
Copy link
Collaborator

mheiman commented Dec 6, 2024

This may be fine, but I want to be sure we've thought it through. We have a lot of practices that are essentially "You should always do X (unless there's a very good reason to do Y)" so I'm wary of changes that make it impossible to do Y.

@ronibhakta1

This comment was marked as outdated.

@RayBB

This comment was marked as outdated.

@ronibhakta1

This comment was marked as outdated.

@cdrini

This comment was marked as outdated.

@seabelis
Copy link
Collaborator

The case where you don't want to include the first listed author in the merge at all does exist.

@RayBB
Copy link
Collaborator Author

RayBB commented Dec 12, 2024

@seabelis in this case I'd expect that the person merging could select the 2nd and 3rd authors (for example). Or is there an edge case I'm missing?

@seabelis
Copy link
Collaborator

No, probably I was missing something. As long as that remains possible, all good.

@mekarpeles mekarpeles added Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Lead: @seabelis Issuses overseen by Lisa (Staff: Lead Community Librarian) [managed] and removed Needs: Lead labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @seabelis Issuses overseen by Lisa (Staff: Lead Community Librarian) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
Status: I'd like to work on it
Development

No branches or pull requests

7 participants