Fixed: Persist Book IDs Across Add Book Dialogs for Regular Users #10195
Conversation
|
Thanks for this, @SharkyBytes. This is a good start. I am not sure of the reason why adding Internet Archive identifiers was limited to admins, but appears intentional, so I will try to find out the rationale. Then, if it makes sense to change, we can work on that part. Additionally, there is an issue with selections being cleared when the validation format is incorrect. I believe that is what is causing the behavior that was originally reported in #10148. That behavior may need some reconsideration. It may just be that these lines need to go: openlibrary/openlibrary/plugins/openlibrary/js/add-book.js Lines 164 to 166 in 1e7fce7 The wiki has a section on Building CSS and JS that would help here. I also left some comments in #10148 that may be worth a look. |
|
Hi @scottbarnes , I’ve raised the issue as #10203 regarding the behavior where the ID selections in the Add-Book form are cleared upon entering an ID number (this occurs even for valid IDs). I’ve mentioned you in the issue for reference, and I believe this is directly related to the concern from #10148. I will raise a PR for this as soon as possible. Could you please take this as a lead? Thanks for your help on this! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10195 +/- ##
==========================================
- Coverage 17.44% 17.44% -0.01%
==========================================
Files 89 89
Lines 4792 4793 +1
Branches 848 849 +1
==========================================
Hits 836 836
Misses 3436 3436
- Partials 520 521 +1 ☔ View full report in Codecov by Sentry. |
Closes #10148 - "Added Book IDs on new books aren't set"
Fix: This PR ensures that the "Internet Archive ID" field in the "Add Book" dialog is correctly persisted across different stages for regular users.
Technical
->Fixed the issue where the "Internet Archive ID" field would not retain its value for regular users after switching steps in the "Add Book" form.
->Ensured that the value entered in the "Internet Archive ID" field is preserved when moving between steps in both admin and user portals.
Testing
Tested locally by logging in as both an admin and a regular user.
Screenshot
Stakeholders
I have worked on this issue with @scottbarnes as lead